Skip to content

Upgrade to xunit.v3#8

Merged
eiriktsarpalis merged 2 commits into
mainfrom
xunitv3
Mar 20, 2025
Merged

Upgrade to xunit.v3#8
eiriktsarpalis merged 2 commits into
mainfrom
xunitv3

Conversation

@stephentoub

Copy link
Copy Markdown
Contributor

No description provided.

@stephentoub stephentoub requested a review from halter73 March 20, 2025 03:51
@stephentoub stephentoub requested review from eiriktsarpalis and removed request for halter73 March 20, 2025 03:56
Comment thread Directory.Packages.props Outdated
<PackageVersion Include="System.Linq.AsyncEnumerable" Version="$(System10Version)" />
<PackageVersion Include="xunit" Version="2.9.2" />
<PackageVersion Include="xunit.runner.visualstudio" Version="3.0.0" />
<PackageVersion Include="xunit.v3" Version="2.0.0" />

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an unresolved issue with xunit.v3 >= 2.0.0 and Rider. I would recommend using 1.0.x for now until it gets resolved.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<PackageVersion Include="xunit.v3" Version="2.0.0" />
<PackageVersion Include="xunit.v3" Version="1.1.0" />

@eiriktsarpalis eiriktsarpalis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Would it be possible to apply the newly introduced Assert.Skip in the integration tests lacking an environment? It's the ones where we just return early today.

@eiriktsarpalis eiriktsarpalis merged commit 27ba8b1 into main Mar 20, 2025
@eiriktsarpalis eiriktsarpalis deleted the xunitv3 branch March 20, 2025 14:19
PranavSenthilnathan added a commit to PranavSenthilnathan/csharp-sdk that referenced this pull request Jun 11, 2026
- Docs: clarify IMcpTaskStore strong-consistency contract (SEP-2663 modelcontextprotocol#306)
  on CreateTaskAsync and document the singleton requirement under stateless
  HTTP; extend tasks.md custom-store requirements list to match (modelcontextprotocol#5, modelcontextprotocol#7).
- Tests: add RootsTool fixture + E2E test covering server-initiated
  roots/list redirection through the task store (modelcontextprotocol#6); add two E2E tests
  for SendTaskStatusNotificationAsync covering the Working/Completed and
  Failed branches (modelcontextprotocol#9); add McpServerTasksNoStoreTests pinning the silent
  sync fallback when a client opts into tasks but no TaskStore is
  configured (modelcontextprotocol#8).
- Rename CompletedTaskResult.TaskResult and CompletedTaskNotificationParams.TaskResult
  to Result for consistency with the JSON wire name. Wire format unchanged.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants