Revert "chore: use double spaces when marshalling manifests/indexes"#3539
Closed
jedevc wants to merge 1 commit intomoby:v0.11from
Closed
Revert "chore: use double spaces when marshalling manifests/indexes"#3539jedevc wants to merge 1 commit intomoby:v0.11from
jedevc wants to merge 1 commit intomoby:v0.11from
Conversation
ced9046 to
f83d3f4
Compare
This reverts commit b5f427a. Signed-off-by: Justin Chadwell <me@jedevc.com>
f83d3f4 to
0fc47e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit b5f427a.
Ideally, we wouldn't need this - but apparently, docker manifest relies on a very specific indentation level: see docker/cli#3990, for the docker manifest fix that would correct this.
However, because of release timings, we could probably attempt to revert the buildkit change, at least for 0.11 - by our next major release, users should be able to get the new docker manifest command.