Open
Conversation
Contributor
Author
|
@suachong - can you please review this? |
Contributor
Author
|
@pgmpablo157321 @pbaumstarck can you please approve and merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running this parsing script from small_llm_moe_pretraining/primus/rcp_logs gives different samples to converge for GBS32 but this looks more realistic.
Given that GBS16 takes about 195k samples to converge
The old RCPs for GBS32 was converging in ~179k samples which doesn't make sense
The new RCPs for GBS32 converge in 235k which is a lot more reasonable and match the logs provided.