Add support for generated columns#53
Merged
mla merged 3 commits intoFeb 17, 2024
Merged
Conversation
Contributor
Author
|
I need to fix a problem with the FK constraints, nearly got it but it means some changes elsewhere to push the columns into the table object. |
Contributor
Author
|
I think I've fixed it, but I'm testing it at an approximately 30% sample rate on our 120GB staging database as a torture test and I'll update the PR if it's successful. |
This change ensures that foreign key checks on tables with generated columns work properly.
Owner
|
Looks great to me, @nicholasd-ff. Changes merged. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for sampling tables with generated columns
This change adds support for sampling tables with generated columns
and tests to check the new feature is working correctly.
Fixes #52
Test output: