Skip to content

feat(settings): reach the GUI via a Start-menu shortcut (Win11 fix) - #31

Merged
mkpoli merged 1 commit into
masterfrom
feat/settings-shortcut
Jun 27, 2026
Merged

feat(settings): reach the GUI via a Start-menu shortcut (Win11 fix)#31
mkpoli merged 1 commit into
masterfrom
feat/settings-shortcut

Conversation

@mkpoli

@mkpoli mkpoli commented Jun 20, 2026

Copy link
Copy Markdown
Owner

Fixes your #1: "we still don't see GUI anywhere."

Root cause: on Windows 11 the floating language bar is hidden by default, so the langbar "設定 / Settings…" menu (#26) never appears — and TSF doesn't expose an "Options" button for third-party TIPs. So the settings dialog had no reachable entry point, even though config.toml works.

Fix — a Start-menu shortcut, independent of the language bar:

  • Export ShowSettings (rundll32 CALLBACK signature) from the DLL → calls settings_dialog::show. Added to ainuKey.def; verified present in the cross-linked DLL's export table (5 exports now).
  • Installer [Icons]: "ainuKey Settings"rundll32.exe "<app>\ainukey.dll",ShowSettings.
  • settings_dialog::show now SetForegroundWindow(dialog) so it pops to the front instead of opening behind the active window.

⚠️ Needs a Windows run to confirm rundll32 opens the dialog and the shortcut works. Build + export verified on Linux (cargo xwin + objdump).

Note: changing settings via this dialog (a separate rundll32 process) writes config.toml; the running IME picks it up on its next activation (switch away/back) — same as hand-editing the file.

Stacking note: the [Icons] addition is a different region of ainuKey.iss than #29's [Languages]/[Messages], so they should merge cleanly.

On Windows 11 the floating language bar is hidden by default, so the langbar
"設定 / Settings…" menu (PR #26) never appears — and TSF doesn't surface an
"Options" button for third-party TIPs either. The settings dialog was therefore
unreachable in the GUI, even though config.toml worked.

Fix: a Start-menu shortcut that opens the dialog directly, independent of the
language bar.

- Export `ShowSettings` (rundll32 CALLBACK signature) from the DLL — it calls
  settings_dialog::show. Added to ainuKey.def; verified in the cross-linked DLL's
  export table (now 5 exports).
- Installer [Icons]: "ainuKey Settings" → rundll32.exe "<app>\ainukey.dll",ShowSettings.
- settings_dialog::show now SetForegroundWindow(dialog) so it pops to the front
  instead of opening behind the active window.

⚠️ Needs a Windows run to confirm rundll32 opens the dialog and the shortcut
works; build + export verified on Linux (cargo xwin + objdump).
@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@mkpoli, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 25 minutes and 50 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 387140f0-3e76-466b-b8cb-27acdb42be92

📥 Commits

Reviewing files that changed from the base of the PR and between 2dbb794 and c4bea94.

📒 Files selected for processing (4)
  • ainuKey.def
  • installer/ainuKey.iss
  • src/lib.rs
  • src/settings_dialog.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/settings-shortcut

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mkpoli
mkpoli force-pushed the feat/settings-shortcut branch from 0551a58 to 3d6275e Compare June 27, 2026 07:22
@mkpoli
mkpoli force-pushed the feat/settings-shortcut branch from 3d6275e to c4bea94 Compare June 27, 2026 10:20
@mkpoli
mkpoli merged commit dea9b55 into master Jun 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant