Skip to content

Use improved syntax file from https://github.com/vim-python/python-syntax#4

Open
sloria wants to merge 1 commit intomitsuhiko:masterfrom
sloria:better-syntax
Open

Use improved syntax file from https://github.com/vim-python/python-syntax#4
sloria wants to merge 1 commit intomitsuhiko:masterfrom
sloria:better-syntax

Conversation

@sloria
Copy link
Copy Markdown

@sloria sloria commented May 1, 2016

This copies the syntax file from vim-python/python-syntax, which improves syntax highlighting.

closes #3

@lithammer
Copy link
Copy Markdown
Contributor

Better yet, use https://github.com/vim-python/python-syntax

@sloria sloria changed the title Use improved syntax file from https://github.com/hdima/python-syntax Use improved syntax file from https://github.com/vim-python/python-syntax May 31, 2017
@sloria
Copy link
Copy Markdown
Author

sloria commented May 31, 2017

Thanks for the tip, @Renstrom . It appears that vim-python/python-syntax is the most actively-maintained fork ATM. I've updated this PR to use that instead.

@mitsuhiko Please let me know if there are any blockers to getting this merged.

@mitsuhiko
Copy link
Copy Markdown
Owner

Doesn't that defeat the purpose of the repo here? The entire point is that you don't have to set the version of the language.

@sloria
Copy link
Copy Markdown
Author

sloria commented May 31, 2017

I don't think it defeats the purpose. The syntax file from vim-python/python-syntax is the best I've seen, and even though you can explicitly specify a Python version, it works out-of-the-box for both versions (I'm currently using it in both Py2 and Py3 codebases).

The value of this repo is that it combines syntax highlighting and pep8 indentation, and consequently is easily integrated by vim-polyglot. If this is merged, I would be able to remove my special-casing for Python (see https://github.com/sloria/dotfiles/blob/9b34d1a4ec4ad4942419b7e93ac60027159240ec/roles/vim/files/vimrc#L147-L154).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better syntax file?

3 participants