MOBILE-220: add named firebase instance#731
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for using a host-configured, named FirebaseApp instance for Mindbox’s FCM token retrieval (to isolate Mindbox from churn on the [DEFAULT] app token), plus a small logging fix in the core SDK.
Changes:
- Add optional
mindbox_firebase_app_namestring resource and logic to create/reuse a namedFirebaseAppbased on[DEFAULT]options. - Route token retrieval through the named app when configured, with fallback to
[DEFAULT]on resolution failure. - Add unit tests covering default/named/fallback paths and memoization of the resource lookup; fix a log message variable in
Mindbox.updateAppInfo.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| sdk/src/main/java/cloud/mindbox/mobile_sdk/Mindbox.kt | Fixes incorrect variable used in an updateAppInfo log message. |
| mindbox-firebase/src/main/java/cloud/mindbox/mindbox_firebase/FirebaseServiceHandler.kt | Adds named-app creation and named/default FCM token resolution with memoized app-name lookup. |
| mindbox-firebase/src/main/res/values/strings.xml | Introduces optional mindbox_firebase_app_name configuration resource. |
| mindbox-firebase/src/test/kotlin/cloud/mindbox/mindbox_firebase/FirebaseServiceHandlerTest.kt | Adds tests for named-app creation, token resolution, fallback behavior, and resource memoization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
enotniy
reviewed
Jun 26, 2026
| a token isolated from the [DEFAULT] FirebaseApp (whose token third-party SDKs | ||
| may churn). Empty by default — Mindbox then uses the [DEFAULT] FirebaseApp. | ||
| --> | ||
| <string name="mindbox_firebase_app_name" translatable="false" /> |
Collaborator
There was a problem hiding this comment.
Проверял, как будет себя вести приложение, если при обновлении поменять? ТОкен поменяется?
Collaborator
Author
There was a problem hiding this comment.
Проверял, меняется
В кейсы приемки тоже этот кейс добавил
enotniy
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.yandex.ru/MOBILE-220