Comment and Reply ResponseData now contains Heart#51
Open
linuxlight wants to merge 12 commits into
Open
Conversation
…mentHeartRepository interface
…mentHeart method at CommentHeartService class
…entResponseData method in Comment class
…entResponseData method in Reply class
mikekang47
reviewed
Mar 24, 2022
| if (userComments.isEmpty()) | ||
| throw new CommentNotFoundException(); | ||
| return getCommentResponseDataList(userComments); | ||
| return userComments; |
Owner
There was a problem hiding this comment.
dto 변환 위치 변경하시느라 고생 많으셨습니다 :)
Comment on lines
+49
to
+50
| List<Comment> comments = commentService.getComments(); | ||
| return comments.stream().map(Comment::toCommentResponseData).collect(Collectors.toList()); |
| .commentId(id) | ||
| .userProfile(user.toUserProfileData()) | ||
| .content(content) | ||
| .heartPresent(hearts.stream().anyMatch(heart -> heart.getUser().equals(user))) |
Owner
There was a problem hiding this comment.
anyMat를 사용하면 객체끼리 바로 비교가 가능한가보군요!
찾아 봐야겠어요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.