feat: add feature selection options to build command#665
Open
svasista-ms wants to merge 15 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends cargo wdk build with standard Cargo feature-selection flags and forwards them through the internal Cargo calls used by the build pipeline, making it easier to build driver projects with specific feature sets enabled.
Changes:
- Added
--all-features,--no-default-features, and-F/--featurestocargo wdk buildvia a newFeatureArgsstruct. - Forwarded feature-selection flags to
cargo metadata,cargo build, and thecargo rustc -- --print cfginvocation used for target-arch detection. - Refactored
BuildTask::newto take aBuildTaskParamsstruct and updated tests + README accordingly.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/cargo-wdk/src/cli.rs | Exposes feature-selection flags on the build subcommand and wires them into BuildActionParams. |
| crates/cargo-wdk/src/actions/mod.rs | Introduces FeatureArgs and a helper to emit equivalent Cargo CLI args. |
| crates/cargo-wdk/src/actions/build/mod.rs | Plumbs feature args through build orchestration, metadata, and rustc --print cfg path. |
| crates/cargo-wdk/src/actions/build/build_task.rs | Refactors BuildTask construction and forwards feature args to the cargo build invocation (with tests). |
| crates/cargo-wdk/src/actions/build/tests.rs | Updates test scaffolding to carry feature-selection args through BuildAction initialization. |
| crates/cargo-wdk/README.md | Documents the new flags and provides an example usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wmmc88
previously requested changes
Jun 8, 2026
…e related documentation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #665 +/- ##
==========================================
+ Coverage 79.78% 79.93% +0.15%
==========================================
Files 26 26
Lines 5590 5633 +43
Branches 5590 5633 +43
==========================================
+ Hits 4460 4503 +43
- Misses 1001 1002 +1
+ Partials 129 128 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…metadata feature Enabling the cargo_metadata feature on clap-cargo adds cargo_metadata, serde, and serde_json as transitive deps. The cargo-wdk test fixtures are independent workspaces that path-depend on wdk-build (which uses clap-cargo), so their Cargo.lock files need the new transitive entries for cargo metadata --locked to succeed. This unblocks kmdf_driver_builds_successfully_with_locked_flag.
gurry
reviewed
Jun 9, 2026
krishnakumar4a4
previously approved these changes
Jun 15, 2026
gurry
reviewed
Jun 18, 2026
gurry
approved these changes
Jun 22, 2026
The requested changes have been already made. Dismissing requested change to unblock the merging of the PR.
krishnakumar4a4
approved these changes
Jun 22, 2026
Contributor
|
@copilot The merge is failing due to a transient network error. Can you keep retrying the merge until it succeeds? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds standard cargo feature-selection flags to
cargo wdk buildFunctional Changes
cargo wdk buildfor feature-selection.cargoinvocations:cargo metadata,cargo buildandcargo rustcResolves #434
Screenshots
cargo wdk build --helpcargo wdk build --sample --features hidonexamples/sample-kmdf-driverVerbose Output showing features flag being forwarded to the
cargo buildinvocation: