Skip to content

Enable default compile items for Microsoft.TestPlatform.PlatformAbstractions - #2556

Merged
Haplois merged 1 commit into
microsoft:masterfrom
sharwell:all-files
Sep 3, 2020
Merged

Enable default compile items for Microsoft.TestPlatform.PlatformAbstractions#2556
Haplois merged 1 commit into
microsoft:masterfrom
sharwell:all-files

Conversation

@sharwell

@sharwell sharwell commented Sep 1, 2020

Copy link
Copy Markdown
Contributor

This change allows all files to show in Solution Explorer, with the content conditionally included according to well-known compile-time definitions.

@nohwnd nohwnd self-assigned this Sep 2, 2020
@nohwnd

nohwnd commented Sep 2, 2020

Copy link
Copy Markdown
Member

I always wondered why they did it this way, instead of the way you propose in this PR. But it never got high enough on my todo list, because it works. Will merge this in few days once we finalize some other changes. Thank you!

@Haplois

Haplois commented Sep 2, 2020

Copy link
Copy Markdown
Contributor

I already did most of this work for my work on adding support for netstandard1.0 to our primitives. @nohwnd, please don't merge until I compare it with mine.

@nohwnd nohwnd assigned Haplois and unassigned nohwnd Sep 2, 2020
@nohwnd

nohwnd commented Sep 2, 2020

Copy link
Copy Markdown
Member

@Haplois it's yours now. @sharwell needs this merged for #2554, but let's merge tomorrow at earliest.

@Haplois Haplois left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am doing some tests, will merge soon.

@Haplois
Haplois merged commit 60d87bb into microsoft:master Sep 3, 2020
@sharwell
sharwell deleted the all-files branch September 3, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants