Skip to content

Introduces editor.experimentalEditContextEnabled and adopts edit context. Closes #207700#227608

Merged
hediet merged 2 commits intomainfrom
hediet/b/impressive-swan
Sep 4, 2024
Merged

Introduces editor.experimentalEditContextEnabled and adopts edit context. Closes #207700#227608
hediet merged 2 commits intomainfrom
hediet/b/impressive-swan

Conversation

@hediet
Copy link
Member

@hediet hediet commented Sep 4, 2024

Set editor.experimentalEditContextEnabled: true to self-host on this.

Known bugs:

  • Long press e doesn't work (bug in electron, workaround in implementation)

Potential issues:

  • Screenreader support needs testing on all platforms/readers
  • Monaco-editor/web support untested

…ext. Closes #207700

Co-authored-by: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
@hediet hediet enabled auto-merge (squash) September 4, 2024 17:55
@hediet hediet self-assigned this Sep 4, 2024
@vs-code-engineering vs-code-engineering bot added this to the September 2024 milestone Sep 4, 2024
aiday-mar
aiday-mar previously approved these changes Sep 4, 2024
@hediet hediet merged commit 288596b into main Sep 4, 2024
@hediet hediet deleted the hediet/b/impressive-swan branch September 4, 2024 18:21
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants