Incompatible with React 19

[daniharo]

This library makes use of React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.ReactCurrentOwner, which is removed in React 19.

Therefore, when trying to use it with React 19, you get "TypeError: Cannot read properties of undefined (reading 'ReactCurrentOwner')".

Reproduction: https://codesandbox.io/p/sandbox/fluentui-react-components-with-react-19-g4g5pw?file=%2Fsrc%2FApp.tsx

The error happens here:

use-disposable/src/useIsStrictMode.ts

Lines 6 to 9 in 3e3d4a3

	export const getCurrentOwner = () =>
	// @ts-ignore - using react internals
	React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.ReactCurrentOwner
	.current;

[ling1726]

#32 should fix the throwing in React 19. However, there are still two tests that fail due to effect ordring differences. Will need to look further there

[layershifter]

Seems that Next.js with their canary versions is also affected, microsoft/fluentui#31930.

[elliot-huffman]

Any Updates?

[layershifter]

@elliot-huffman nope, it's not a high prio item now.

[ibrahim-bayer]

how can we fix it temporarily even for sake of build?

[layershifter]

how can we fix it temporarily even for sake of build?

@ibrahim-bayer there is no way to fix it. It's not fixable by design. I made a refactor #33174 in Fluent to avoid usage of this package, but it breaks in certain scenarios.

[elliot-huffman]

@layershifter, Is this fixed since #33978 is merged?

[layershifter]

@elliot-huffman this package is still broken and we are not going to fix it. The Fluent itself is fixed by microsoft/fluentui#33978