Skip to content

Fix broken main: acceptance source-gen harness leaks nested bin/obj into multi-project asset builds #9504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evangelink merged 2 commits into from
Jun 29, 2026
Merged

Fix broken main: acceptance source-gen harness leaks nested bin/obj into multi-project asset builds #9504

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fefca5c
Opt AssemblyFixtureProvider acceptance asset out of source-gen build
Evangelink Jun 29, 2026
29aa20f
Fix acceptance source-gen harness: exclude nested bin/obj from defaul…
Evangelink Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion test/Utilities/Microsoft.Testing.TestInfrastructure/AcceptanceSourceGen.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,17 @@ private static string BuildPropsContent(string packageId, string versionProperty
MicrosoftTestingPlatformEntryPoint, SelfRegisteredExtensions) be double-compiled into this build.
Re-exclude them here. This runs in CustomBeforeMicrosoftCommonProps (before the SDK seeds
DefaultItemExcludes), so the SDK appends its own excludes after ours.

The nested '**/obj/**;**/bin/**' globs matter for multi-project assets. The reflection build (which
always runs first, into the default bin/Release) leaves a referenced project's outputs on disk, e.g.
'SomeRef/bin/Release/<tfm>/*.dll'. When this (later) source-gen build evaluates the host project, the
SDK's default item globs would otherwise pull those stray DLLs in as None/Content items, and RAR then
treats a wrong-TFM copy (for example a net10.0 'MSTest.TestFramework.Extensions.dll', assembly version
9.0.0.0) as a candidate for the net8.0 leg -> MSB3277, which MSBuildTreatWarningsAsErrors promotes to an
error. The root-level 'bin/**;obj/**' does not match the nested 'SomeRef/bin/**', so exclude nested
bin/obj as well to keep a referenced project's leftover reflection outputs out of this build's globs.
-->
<DefaultItemExcludes>$(DefaultItemExcludes);obj/**;bin/**</DefaultItemExcludes>
<DefaultItemExcludes>$(DefaultItemExcludes);obj/**;bin/**;**/obj/**;**/bin/**</DefaultItemExcludes>
</PropertyGroup>
<ItemGroup>
<!--
Expand Down