[test-improver] test: add edge case tests for UseRetryWithTestMethodAnalyzer (MSTEST0035)

[Evangelink]

🤖 Test Improver — automated AI assistant focused on improving tests for this repository.

Goal and Rationale

UseRetryWithTestMethodAnalyzer (MSTEST0035) had only 7 tests covering the basic "retry on test method" and "retry on test class" paths, but missed several real-world scenarios:

1. [DataTestMethod] with [Retry] — DataTestMethodAttribute inherits from TestMethodAttribute. Without a test for this, a refactor of the inheritance check could silently start reporting [DataTestMethod] methods as false positives.
2. [TestInitialize] with [Retry] — Fixture methods are not test methods. A developer might accidentally put [Retry] on a [TestInitialize] method expecting it to retry; the analyzer should flag this.
3. Method in a non-test class with [Retry] — The existing diagnostic test only covered methods inside a [TestClass]. A method in a helper class with no [TestClass] decorator should also be flagged.

Approach

• Added WhenDataTestMethodHasRetryAttribute_NoDiagnostic: confirms the Inherits(testMethodAttributeSymbol) check correctly covers the DataTestMethod → TestMethod inheritance chain.
• Added WhenTestInitializeHasRetryAttribute_Diagnostic: confirms fixture attributes do not satisfy the "test method" guard.
• Added WhenMethodInNonTestClassHasRetryAttribute_Diagnostic: confirms the method-level check fires regardless of whether the containing class is a [TestClass].

Coverage Impact

Not measured separately; these tests exercise existing analyzer code paths with no production changes.

Test Status

✅ All 10 tests passed (MSTest.Analyzers.UnitTests net8.0):

Test run summary: Passed!
  total: 10
  failed: 0
  succeeded: 10
  skipped: 0
  duration: 6s 128ms

Reproducibility

./build.sh --restore   # first run only, installs .NET SDK
.dotnet/dotnet test test/UnitTests/MSTest.Analyzers.UnitTests/MSTest.Analyzers.UnitTests.csproj \
  -f net8.0 --no-build -c Debug \
  --filter "ClassName=MSTest.Analyzers.Test.UseRetryWithTestMethodAnalyzerTests"

Generated by Test Improver · sonnet46 7.6M · ◷

Add this agentic workflows to your repo

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/test-improver.md@main

[Copilot]

Pull request overview

This PR expands the unit test coverage for the MSTest analyzer UseRetryWithTestMethodAnalyzer (MSTEST0035) by adding edge-case scenarios to prevent regressions around what constitutes a valid “test method” target for [Retry].

Changes:

• Added a no-diagnostic test ensuring [DataTestMethod] (which derives from TestMethodAttribute) is treated as a valid target for [Retry].
• Added a diagnostic test ensuring fixture methods like [TestInitialize] are flagged when annotated with [Retry].
• Added a diagnostic test ensuring methods in non-[TestClass] helper classes are still flagged when annotated with [Retry].

Show a summary per file

File	Description
test/UnitTests/MSTest.Analyzers.UnitTests/UseRetryWithTestMethodAnalyzerTests.cs	Adds three edge-case tests covering [DataTestMethod], [TestInitialize], and non-test-class methods annotated with [Retry].

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 0

[Evangelink]

/review

[github-actions]

❌ Expert Code Review (command) failed. Please review the logs for details.