Skip to content

[perf-improver] perf: convert InternalOnlyExtensions from array property to static readonly HashSet #8717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Evangelink wants to merge 1 commit into from
Closed

[perf-improver] perf: convert InternalOnlyExtensions from array property to static readonly HashSet #8717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Platform/Microsoft.Testing.Platform/Services/ServiceProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ internal sealed class ServiceProvider : IServiceProvider, ICloneable
public bool AllowTestAdapterFrameworkRegistration { get; set; }

#pragma warning disable CS0618 // Type or member is obsolete
private static Type[] InternalOnlyExtensions =>
private static readonly HashSet<Type> InternalOnlyExtensions =

@Youssef1313 Youssef1313 May 31, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is going to be faster.

Searching in array with small number of elements is usually actually faster than HashSet.

[
// TestHost
typeof(ITestHostApplicationLifetime),
Expand Down
Loading