Disable MSTEST0067 by default#8678
Merged
Evangelink merged 1 commit intoMay 29, 2026
Merged
Conversation
MSTEST0067 (AvoidThreadSleepAndTaskWaitInTestsAnalyzer) was enabled by default with Info severity, which causes the AnalyzerSeverityDecider to elevate it to Warning in the Recommended analysis mode (the default MSTest mode). To keep it discoverable but opt-in, switch isEnabledByDefault to false so the rule only surfaces in the All analysis mode while remaining at Info severity. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downgrades the effective severity of
MSTEST0067(AvoidThreadSleepAndTaskWaitInTestsAnalyzer) by switchingisEnabledByDefaultfromtruetofalse.Why
MSTEST0067was introduced in #8646 withDefaultSeverity = InfoandisEnabledByDefault = true. With those settings theAnalyzerSeverityDeciderelevates it to Warning inRecommendedmode (the default MSTest analysis mode) and inAllmode — which is more intrusive than intended for this stylistic guidance.Marking the rule as not enabled by default keeps the default severity at
Infoand ensures it only surfaces inAllmode, where users explicitly opt into the most aggressive analyzer set. The rule remains fully available and can be turned on individually via.editorconfig.Changes
AvoidThreadSleepAndTaskWaitInTestsAnalyzer.cs:isEnabledByDefault: true→false.AnalyzerReleases.Unshipped.md: severity column forMSTEST0067updated fromInfotoDisabledto match the convention used for other opt-in rules (e.g.MSTEST0021,MSTEST0026).