Skip to content

Remove misleading TreeNodeFilter test added by PR #7415 #8663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evangelink merged 1 commit into from
May 28, 2026
Merged

Remove misleading TreeNodeFilter test added by PR #7415 #8663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions test/UnitTests/Microsoft.Testing.Platform.UnitTests/Requests/TreeNodeFilterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,21 +80,6 @@ public void OrExpression_WorksForSinglePathSegmentInsideParentheses()
Assert.IsFalse(filter.MatchesFilter("/A/B/C/MyTest3", new PropertyBag()));
}

[TestMethod]
public void LiteralSegment_RequiresWildcardToMatchNodesWithAdditionalSuffix()
{
// Note: This documents a current limitation that often surprises users.
// Path segments are matched against an anchored regex (^value$), so a literal
// like 'MyTest1' will NOT match a node whose actual ID is 'MyTest1()' (e.g. when
// a framework appends parameter/method-signature info to the displayed name).
// Users observing this typically need to add a wildcard: '/*/*/*/(MyTest1*|MyTest2*)'.
// See https://github.com/microsoft/testfx/issues/7300 for the user-facing report.
TreeNodeFilter filter = new("/*/*/*/(MyTest1|MyTest2)");

Assert.IsFalse(filter.MatchesFilter("/A/B/C/MyTest1()", new PropertyBag()));
Assert.IsFalse(filter.MatchesFilter("/A/B/C/MyTest2()", new PropertyBag()));
}

[TestMethod]
public void FullPathOrInsideParenthesizedExpressions_IsNotSupported_ThrowsActionableMessage()
{
Expand Down
Loading