Skip to content

Fix CA1305 in Assert.That test (int.ToString() needs IFormatProvider) #8358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evangelink merged 1 commit into from
May 19, 2026
Merged

Fix CA1305 in Assert.That test (int.ToString() needs IFormatProvider) #8358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/UnitTests/TestFramework.UnitTests/Assertions/AssertTests.That.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1157,7 +1157,7 @@ public void That_Coalesce_ShortCircuit_PassingAssertion_DoesNotInvokeRight()
string? value = "hello";

// Non-null value short-circuits the null-coalescing operator; counter.Increment() must NOT run.
Action act = () => Assert.That(() => (value ?? counter.Increment().ToString()) == "hello");
Action act = () => Assert.That(() => (value ?? counter.Increment().ToString(CultureInfo.InvariantCulture)) == "hello");

act.Should().NotThrow();
counter.Count.Should().Be(0);
Expand Down
Loading