Skip to content

Enable anti-flicker progress version check in AnsiTerminalTestProgressFrame #8348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evangelink merged 2 commits into from
May 19, 2026
Merged

Enable anti-flicker progress version check in AnsiTerminalTestProgressFrame #8348

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd86b27
Enable anti-flicker progress version check in AnsiTerminalTestProgres…
May 19, 2026
a826ced
Fix per-line indexing in progress frame Render loop
May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ...latform/Microsoft.Testing.Platform/OutputDevice/Terminal/AnsiTerminalTestProgressFrame.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,12 +210,14 @@ public void Render(AnsiTerminalTestProgressFrame previousFrame, TestProgressStat
terminal.AppendLine();
}

int i = 0;
int i;
RenderedLines = [with(progress.Length * 2)];
List<object> progresses = GenerateLinesToRender(progress);

foreach (object item in progresses)
for (i = 0; i < progresses.Count; i++)
{
object item = progresses[i];

if (previousFrame.RenderedLines != null && previousFrame.RenderedLines.Count > i)
{
if (item is TestProgressState progressItem)
Expand All @@ -225,7 +227,7 @@ public void Render(AnsiTerminalTestProgressFrame previousFrame, TestProgressStat

// We have a line that was rendered previously, compare it and decide how to render.
RenderedProgressItem previouslyRenderedLine = previousFrame.RenderedLines[i];
if (previouslyRenderedLine.ProgressId == progressItem.Id && false)
if (previouslyRenderedLine.ProgressId == progressItem.Id && previouslyRenderedLine.ProgressVersion == progressItem.Version)
{
Comment thread
Evangelink marked this conversation as resolved.
// This is the same progress item and it was not updated since we rendered it, only update the timestamp if possible to avoid flicker.
string durationString = HumanReadableDurationFormatter.Render(progressItem.Stopwatch.Elapsed);
Expand Down
Loading