-
Notifications
You must be signed in to change notification settings - Fork 296
Fix path for post-build template and adjust validation #7615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -253,4 +253,7 @@ extends: | |
| LclSource: lclFilesfromPackage | ||
| LclPackageId: 'LCL-JUNO-PROD-TESTFX' | ||
|
|
||
| - template: eng\common\templates-official\post-build\post-build.yml@self | ||
| - template: eng/common/templates-official/post-build/post-build.yml@self | ||
| parameters: | ||
| # Temporarily disable signing validation until infra issues are resolved, based on advice from Arcade. | ||
| enableSigningValidation: False | ||
|
Comment on lines
+257
to
+259
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Template includes in this pipeline generally use an absolute repo-root path (leading
/), but this one is still relative (eng/common/...). To keep things consistent with the other template references in this file (and avoid any path-resolution ambiguity if the file is ever relocated), consider switching this to/eng/common/templates-official/post-build/post-build.yml@self.