Skip to content

Report the actual exception from assertion#6989

Closed
nohwnd wants to merge 2 commits into
mainfrom
output-actual-exception-from-throw-assertions
Closed

Report the actual exception from assertion#6989
nohwnd wants to merge 2 commits into
mainfrom
output-actual-exception-from-throw-assertions

Conversation

@nohwnd

@nohwnd nohwnd commented Nov 26, 2025

Copy link
Copy Markdown
Member

Partially fix #6906

The data are there, but the formatting is not great.

@Evangelink Evangelink enabled auto-merge (squash) December 5, 2025 11:05
@Evangelink

Copy link
Copy Markdown
Member

Given this was not merged yet, I would recommend changing this PR to use feature provided by #7098

@Evangelink

Copy link
Copy Markdown
Member

@copilot please revert changes to the message and instead pass the actual exception to ThrowAssertFailed.

Copilot AI commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

@Evangelink I've opened a new pull request, #7124, to work on those changes. Once the pull request is ready, I'll request review from you.

@Evangelink Evangelink closed this Dec 15, 2025
auto-merge was automatically disabled December 15, 2025 11:47

Pull request was closed

@Evangelink Evangelink deleted the output-actual-exception-from-throw-assertions branch December 15, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assert.Throws should print the actual exception.

4 participants