Show running tests#4221
Merged
Merged
Conversation
Closed
Make the number of active tests to render based on the size of the terminal.
Member
|
Looking dope!
I do see a few flickering effect depending on machine load. |
Member
|
True. My only objection is the “and 1 more”, just show the test that is running :)
…-j
________________________________
Od: Amaury Levé ***@***.***>
Odesláno: Wednesday, December 4, 2024 9:08:48 PM
Komu: microsoft/testfx ***@***.***>
Kopie: Subscribed ***@***.***>
Předmět: Re: [microsoft/testfx] Show running tests (PR #4221)
Looking dope!
progress-1000-tests.gif (view on web)<https://github.com/user-attachments/assets/d7ea6295-49b5-4487-918d-6a59509193b8>
I do see a few flickering effect depending on machine load.
—
Reply to this email directly, view it on GitHub<#4221 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABLYLYIVRWJ6CX2Y3YSLBLT2D5ONBAVCNFSM6AAAAABS5WNEV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJYGQ2TSNJRGA>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Member
Yes! |
nohwnd
reviewed
Dec 5, 2024
Evangelink
reviewed
Dec 5, 2024
Member
|
I think it'd be nice to also update the message |
Member
Author
|
Specialized the message when no active tests can be shown on the terminal |
Evangelink
previously approved these changes
Dec 5, 2024
Evangelink
left a comment
Member
There was a problem hiding this comment.
Functionnaly looking good. @nohwnd I'll let you finish the technical review.
@drognanar How hard would it be to add a few test in TerminalTestReporterTests.cs for the progress?
Evangelink
reviewed
Dec 6, 2024
Evangelink
reviewed
Dec 6, 2024
…TerminalTestReporter.cs Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
nohwnd
reviewed
Dec 6, 2024
nohwnd
approved these changes
Dec 9, 2024
Evangelink
approved these changes
Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3728
Reports the progress of actively running tests: