Fix a crash during settings update #17751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
approved these changes
Aug 20, 2024
zadjii-msft
approved these changes
Aug 20, 2024
DHowett
pushed a commit
that referenced
this pull request
Aug 21, 2024
* Adds a check whether the thread dispatcher is already null. (See code comments.) * Moves the `_settings` to only happen on the UI thread. Anything else wouldn't be thread safe. Closes #17620 ## Validation Steps Performed Not reproducible. 🚫 (cherry picked from commit e0dae59) Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgSGBis Service-Version: 1.21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See code comments.)
_settingsto only happen on the UI thread.Anything else wouldn't be thread safe.
Closes #17620
Validation Steps Performed
Not reproducible. 🚫