Skip to content

Conversation

@lhecker
Copy link
Member

@lhecker lhecker commented Jul 17, 2024

#17574 had 2 bugs, which I failed to notice because I didn't test
the code again after fixing the WaitUntilDSR boolean expression:

  • The VtInputThread needs to be running in order
    for us to see any VT input get parsed.
    • Consequentially, the console lock must be suspended while we wait.
  • Since WaitUntilDSR didn't detect timeouts it would loop forever.
    This wasn't obvious before, because it wouldn't loop at all. (lol)

@lhecker lhecker added Product-Conpty For console issues specifically related to conpty Issue-Bug It either shouldn't be doing this or needs an investigation. labels Jul 17, 2024
@DHowett DHowett merged commit 1feb56e into main Jul 17, 2024
@DHowett DHowett deleted the dev/lhecker/17510-fix-cursor-inheritance branch July 17, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Conpty For console issues specifically related to conpty

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants