Skip to content

URL nil check#789

Merged
HeyImChris merged 18 commits intomicrosoft:0.63-stablefrom
HeyImChris:63_urlNilCheck
Jun 1, 2021
Merged

URL nil check#789
HeyImChris merged 18 commits intomicrosoft:0.63-stablefrom
HeyImChris:63_urlNilCheck

Conversation

@HeyImChris
Copy link

@HeyImChris HeyImChris commented May 28, 2021

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

git cherry-pick 415abb553e33e93586e7c74a36f8eddb0266dc6d

HeyImChris and others added 18 commits February 4, 2021 11:38
@HeyImChris
Add nullability checks (microsoft#704)
6f008d6 
* Update RCTCxxBridge.mm

* add nullability checks
@HeyImChris
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
a973d02 
…ve-macos into 0.63-stable
@HeyImChris
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
a265b19 
…ve-macos into 0.63-stable
@HeyImChris
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
02f7a84 
…ve-macos into 0.63-stable
@HeyImChris
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
fcc450d 
…ve-macos into 0.63-stable
@HeyImChris
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
4f93eef 
…ve-macos into 0.63-stable
@HeyImChris
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
6b1f7df 
…ve-macos into 0.63-stable
@HeyImChris
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
f341932 
…ve-macos into 0.63-stable
@HeyImChris
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
2fb8131 
…ve-macos into 0.63-stable
@HeyImChris
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
7a9a99f 
…ve-macos into 0.63-stable
@HeyImChris
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
2ec3692 
…ve-macos into 0.63-stable
@HeyImChris
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
b20bc04 
…ve-macos into 0.63-stable
@HeyImChris
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
2496154 
…ve-macos into 0.63-stable
@HeyImChris
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
894748c 
…ve-macos into 0.63-stable
@HeyImChris
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
36fcf6b 
…ve-macos into 0.63-stable
@HeyImChris
Merge branch '0.63-stable' of https://github.com/microsoft/react-nati…
ae62c76 
…ve-macos into 0.63-stable
@HeyImChris
Check a nil URL to fix crashes connecting to socket (microsoft#785)
eb32f12 
* Update RCTCxxBridge.mm

* Update RCTCxxBridge.mm

* nil check websocket URL

* use RCTAssertParam

Co-authored-by: Chris Hogan <chrishogan@Chriss-MacBook-Pro-2.local>
@HeyImChris
pod install
cdeb935
@HeyImChris HeyImChris self-assigned this May 28, 2021
@HeyImChris HeyImChris requested a review from alloy as a code owner May 28, 2021 21:06
@pull-bot
Copy link

pull-bot commented May 28, 2021

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.
Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against cdeb935

@HeyImChris HeyImChris merged commit 1a49ea2 into microsoft:0.63-stable Jun 1, 2021
NickGerleman pushed a commit to NickGerleman/react-native that referenced this pull request Jul 20, 2022
@tido64 @facebook-github-bot
Remove @babel/plugin-transform-regenerator from RN Babel preset (mi…
4b6c0b9 
…crosoft#789)

Summary:
## Summary

Hermes added support for generators in 0.2.0, and JSC is ES6 feature complete since r202125.

NOTE: This is a combined Metro + React Native commit. For React Native, the only change here is adding `babel/plugin-transform-regenerator` to `repo-config` ( = `devDependencies`), so the tests no longer implicitly consume it via Metro.

Changelog: [Internal]

X-link: facebook/metro#789

Reviewed By: rh389

Differential Revision: D34819044

Pulled By: motiz88

fbshipit-source-id: fe27b2c2af0281d5309d4c16f95762d4d4935eba
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 15, 2023
@tido64 @Saadnajmi
Remove @babel/plugin-transform-regenerator from RN Babel preset (mi…
c9e26f1 
…crosoft#789)

Summary:
## Summary

Hermes added support for generators in 0.2.0, and JSC is ES6 feature complete since r202125.

NOTE: This is a combined Metro + React Native commit. For React Native, the only change here is adding `babel/plugin-transform-regenerator` to `repo-config` ( = `devDependencies`), so the tests no longer implicitly consume it via Metro.

Changelog: [Internal]

X-link: facebook/metro#789

Reviewed By: rh389

Differential Revision: D34819044

Pulled By: motiz88

fbshipit-source-id: fe27b2c2af0281d5309d4c16f95762d4d4935eba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Saadnajmi Saadnajmi Saadnajmi approved these changes

@harrieshin harrieshin Awaiting requested review from harrieshin

@alloy alloy Awaiting requested review from alloy

Assignees

@HeyImChris HeyImChris

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HeyImChris @pull-bot @Saadnajmi