[JSCRuntime] Only enable the JSC debugging in DEBUG by default#1976
Merged
Saadnajmi merged 1 commit intomicrosoft:mainfrom Nov 7, 2023
Merged
[JSCRuntime] Only enable the JSC debugging in DEBUG by default#1976Saadnajmi merged 1 commit intomicrosoft:mainfrom
Saadnajmi merged 1 commit intomicrosoft:mainfrom
Conversation
This was referenced Nov 7, 2023
amgleitman
approved these changes
Nov 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary:
#1957 set the JSC debugging to always be true, even on Release builds. Let's ifdef the default so it's only true for debug. This way, we can continue to support allowing a user to enable debugging for release builds if they wish.
Changelog:
[GENERAL] [CHANGED] - Only enable JSC debugging in DEBUG by default
Test Plan:
CI should pass. I couldn't get a good ship build of RN, but this is a fairly simple change.