Skip to content

fix: keep GitHub annotations parseable with dot reporter#41292

Merged
Skn0tt merged 2 commits into
microsoft:mainfrom
mturac:fix/github-reporter-dot-annotations
Jun 16, 2026
Merged

fix: keep GitHub annotations parseable with dot reporter#41292
Skn0tt merged 2 commits into
microsoft:mainfrom
mturac:fix/github-reporter-dot-annotations

Conversation

@mturac

@mturac mturac commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Fixes #41272.

Summary

This keeps GitHub failure annotations parseable when the GitHub reporter is combined with reporters that leave output on the current line, such as the dot reporter.

The fix emits a line break before per-test GitHub failure annotations, so the ::error workflow command starts at the beginning of a line. It also adds a regression for reporter: "dot,github" to ensure the annotation is not written inline after the dot reporter output.

Validation

  • npm run ttest -- reporter-github.spec.ts
  • npx eslint packages/playwright/src/reporters/github.ts tests/playwright-test/reporter-github.spec.ts
  • npm run tsc -- --pretty false
  • npm run build
  • git diff --check

@mturac

mturac commented Jun 14, 2026

Copy link
Copy Markdown
Contributor Author

@mturac please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@mturac
mturac marked this pull request as ready for review June 14, 2026 20:34
@dgozman
dgozman requested a review from Skn0tt June 16, 2026 08:58
@dgozman

dgozman commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

@Skn0tt Could you please take a look?

Comment thread tests/playwright-test/reporter-github.spec.ts Outdated
Signed-off-by: Simon Knott <info@simonknott.de>
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

7341 passed, 1122 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 flaky ⚠️ [chromium-library] › library/video.spec.ts:476 › screencast › should capture static page in persistent context @smoke `@chromium-ubuntu-22.04-node22`

39596 passed, 743 skipped


Merge workflow run.

@Skn0tt
Skn0tt merged commit b54dba5 into microsoft:main Jun 16, 2026
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: GitHub Reporter with the Dot reporter causing the GitHub annotations to print inline

3 participants