fix(chromium): response.body() for worker main script#35692
Merged
dgozman merged 1 commit intoApr 23, 2025
Conversation
This comment has been minimized.
This comment has been minimized.
With `PlzDedicatedWorker` being the default, worker main script starts in the page target and finishes in the worker target. To retrieve the response body, we should update `request.session` in the same way we do that for OOPIF main requests.
dgozman
force-pushed
the
fix-cr-worker-main-script-response-body
branch
from
April 22, 2025 14:48
e5894b0 to
39c96cd
Compare
Contributor
Test results for "tests 1"1 failed 4 flaky39048 passed, 803 skipped Merge workflow run. |
pavelfeldman
approved these changes
Apr 22, 2025
yury-s
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
PlzDedicatedWorkerbeing the default, worker main script starts in the page target and finishes in the worker target.To retrieve the response body, we should update
request.sessionin the same way we do that for OOPIF main requests.Fixes #35678.