chore: test on Node.js 20 #22651
Merged
chore: test on Node.js 20 #22651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d63a5f3 to
133a837
Compare
dgozman
approved these changes
Apr 26, 2023
Contributor
|
Just FYI, the SvelteKit CI is failing on Node 20.0.0, but one of the maintainers figured out it works with the latest nightly release, so perhaps the Node 20 tests here will start passing after the next release of Node 20. |
133a837 to
8cc3e70
Compare
8cc3e70 to
e05afea
Compare
e05afea to
bf889d7
Compare
mxschmitt
commented
May 27, 2023
| node_version: "^18.0.0" | ||
| node_version: 18 | ||
| - os: ubuntu-latest | ||
| node_version: "^16.0.0" |
Contributor
Author
There was a problem hiding this comment.
note: 16 is already tested in tests_primary
bf889d7 to
335677a
Compare
dgozman
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per offline discussion we keep the majority of our bots on Node.js 16 for now, since thats where most of our users are.
This patch does remove Node.js 14 bots, since 14 goes EOL before our next release, see here and adds Node.js 20 bots.
Node.js 20 tests are failing since nodejs/node@5ec0f39 so we had to adjust TestServer a bit.
Fixes #22582