Fix NullReferenceException in ProviderBrowser.LevelSelected when deselecting level#2289
Merged
cincuranet merged 2 commits intomainfrom Aug 26, 2025
Merged
Fix NullReferenceException in ProviderBrowser.LevelSelected when deselecting level#2289cincuranet merged 2 commits intomainfrom
cincuranet merged 2 commits intomainfrom
Conversation
Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] NullReferenceException in ProviderBrowser.LevelSelected
Fix NullReferenceException in ProviderBrowser.LevelSelected when deselecting level
Aug 25, 2025
Member
|
Copilot Post-Mortem:
|
marklio
approved these changes
Aug 25, 2025
Collaborator
marklio
left a comment
There was a problem hiding this comment.
This looks like a reasonable fall-back should the state get unselected, but it would seem to indicate the wrong UI paradigm is being used for selection. Consider a follow-up change to the UI to make the selection more natural and UI-enforced (single-selected radio-button? drop-down? spinner? etc.)
Member
|
Yeah, it is kind of funny that it's a multi-select control but only allows one selection. Will consider a follow-up change. Thanks for the review! |
cincuranet
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LevelSelectedevent handler inProviderBrowser.xaml.cswas callingLevelListBox.SelectedItem.ToString()without null checking, causing a crash when users attempted to deselect the selected level by holding Ctrl and clicking it.Problem
When a user holds Ctrl and clicks the selected item in the Level ListBox:
ListBox.SelectedItembecomesnullLevelSelectedevent handler tries to callSelectedItem.ToString()NullReferenceExceptionSolution
Added defensive null checking that prevents deselection and maintains the requirement that exactly one level must always be selected:
This approach:
NullReferenceExceptionFixes #983.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.