Fix regression: "Goto Item in Callers/Callees" now accumulates across all threads#2284
Merged
Fix regression: "Goto Item in Callers/Callees" now accumulates across all threads#2284
Conversation
…ll threads Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Regression in 3.1.20: "Goto Item in callers" doesnt accumulate across all nodes anymore
Fix regression: "Goto Item in Callers/Callees" now accumulates across all threads
Aug 19, 2025
e0ef259 to
08fae74
Compare
Member
|
Copilot Post-Mortem:
|
marklio
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression in version 3.1.20 where the "Goto Item in Callers" (F10) and "Goto Item in Callees" (Shift+F10) commands stopped accumulating data across all threads and only showed data from the currently selected thread.
Problem
When a user selected a node in the CallTree view and pressed F10 to view its callers, the callers view would only show callers from the specific thread of the selected node, instead of aggregating callers across all threads as it did in version 3.1.19.
Root Cause
The issue was in the
DoViewInCallers,DoViewInCallees, andDoViewInCallerCalleemethods, which were calling:This passes the specific
CallTreeNodeinstance (representing one thread's data) directly toSetFocus. However, double-clicking worked correctly because it called:This uses the string overload of
SetFocus, which looks up the corresponding ByName node that aggregates data across all threads.Solution
Changed all three methods to use the name-based lookup:
This ensures that:
The fix is surgical - only 3 lines changed total, ensuring minimal risk of introducing new issues.
Fixes #2280.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.