Skip to content

Fix regression: "Goto Item in Callers/Callees" now accumulates across all threads#2284

Merged
brianrob merged 3 commits intomainfrom
copilot/fix-2280
Aug 19, 2025
Merged

Fix regression: "Goto Item in Callers/Callees" now accumulates across all threads#2284
brianrob merged 3 commits intomainfrom
copilot/fix-2280

Conversation

Copy link
Contributor

Copilot AI commented Aug 19, 2025

This fixes a regression in version 3.1.20 where the "Goto Item in Callers" (F10) and "Goto Item in Callees" (Shift+F10) commands stopped accumulating data across all threads and only showed data from the currently selected thread.

Problem

When a user selected a node in the CallTree view and pressed F10 to view its callers, the callers view would only show callers from the specific thread of the selected node, instead of aggregating callers across all threads as it did in version 3.1.19.

Root Cause

The issue was in the DoViewInCallers, DoViewInCallees, and DoViewInCallerCallee methods, which were calling:

SetFocus(GetSelectedNodes().Single());

This passes the specific CallTreeNode instance (representing one thread's data) directly to SetFocus. However, double-clicking worked correctly because it called:

SetFocus(asTextBlock.Text);

This uses the string overload of SetFocus, which looks up the corresponding ByName node that aggregates data across all threads.

Solution

Changed all three methods to use the name-based lookup:

- SetFocus(GetSelectedNodes().Single());
+ SetFocus(GetSelectedNodes().Single().Name);

This ensures that:

  • The ByName aggregated view is used instead of thread-specific CallTree nodes
  • F10/Shift+F10 behavior is aligned with double-click behavior
  • Callers and callees are properly accumulated across all threads

The fix is surgical - only 3 lines changed total, ensuring minimal risk of introducing new issues.

Fixes #2280.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…ll threads

Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>
Copilot AI changed the title [WIP] Regression in 3.1.20: "Goto Item in callers" doesnt accumulate across all nodes anymore Fix regression: "Goto Item in Callers/Callees" now accumulates across all threads Aug 19, 2025
Copilot AI requested a review from brianrob August 19, 2025 20:48
@brianrob
Copy link
Member

Copilot Post-Mortem:

  • The immediate fix was correct.
  • I believe that copilot used the functional test to determine what the right fix should be. Ultimately, the functional test was not useful because it doesn't actually test the fix, it just mimics the behavior around the fix, and so I removed it.

@brianrob brianrob marked this pull request as ready for review August 19, 2025 22:05
@brianrob brianrob merged commit a8605fe into main Aug 19, 2025
5 checks passed
@brianrob brianrob deleted the copilot/fix-2280 branch August 19, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression in 3.1.20: "Goto Item in callers" doesnt accumulate across all nodes anymore

3 participants