Fix broken stacks warning for universal traces#2268
Merged
Conversation
…e is ETW-based Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>
Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] CPU stacks shows 100% broken stacks for universal traces
Fix broken stacks warning for universal traces
Jul 23, 2025
Member
|
Copilot Post-Mortem:
|
marklio
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When opening a universal trace in PerfView and viewing CPU stacks, PerfView incorrectly shows a warning about "100% broken stacks" even when the stacks are not actually broken. This happens because the broken stack detection logic was designed specifically for ETW traces but was being applied to all trace types.
Root Cause
The
WarnAboutBrokenStacksmethod inPerfViewStackSourcewas running broken stack analysis on all trace types, but the logic for detecting broken stacks is only applicable to traces that originate from ETW.Solution
Modified the
WarnAboutBrokenStacksmethod to only perform broken stack analysis for ETW-based traces (ETLPerfViewData):DataFileis an instance ofETLPerfViewDataImpact
Testing
Verified the type checking logic works correctly for different trace types:
ETLPerfViewData(ETW traces) → runs broken stack analysisEventPipePerfViewData(universal traces) → skips broken stack analysisLinuxPerfViewData(Linux traces) → skips broken stack analysisFixes #2266.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.