Add AutomationProperties.Name to Process Selection DataGrid for accessibility#2239
Merged
Add AutomationProperties.Name to Process Selection DataGrid for accessibility#2239
Conversation
…sibility Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] The Name property of a focusable element must not be null
Add AutomationProperties.Name to Process Selection DataGrid for accessibility
Jun 13, 2025
Member
|
Co-pilot Post-Mortem:
|
marklio
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an accessibility issue where the DataGrid in the "Select Process Window" popup lacked a proper name for screen readers and assistive technologies.
Problem
When using accessibility tools like "Accessibility Insights for Windows" on the Select Process dialog, the DataGrid element showed as
datagrid ''with an empty name, violating the accessibility requirement that "The Name property of a focusable element must not be null."Solution
Added
AutomationProperties.Name="Process selection table"to the DataGrid element inSelectProcess.xaml. This provides a meaningful, descriptive name for screen readers and follows the established pattern used throughout the PerfView codebase for similar controls.Changes
/src/PerfView/Dialogs/SelectProcess.xamlTesting
Fixes #2238.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.