Skip to content

Fix focus indicator visibility for hyperlinks in dark mode and high contrast #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brianrob merged 6 commits into from
Jun 19, 2025
Merged

Fix focus indicator visibility for hyperlinks in dark mode and high contrast #2235

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
875309a
Initial plan for issue
Copilot Jun 13, 2025
1f754cf
Add focus indicators for hyperlinks in dark theme
Copilot Jun 13, 2025
a0a27df
Fix high contrast dark mode styling for menu, dropdown and filter
Copilot Jun 13, 2025
71fa941
Revert failed high contrast changes and fix light theme menu colors
Copilot Jun 13, 2025
c31b04d
Revert theme changes and fix menu bar high contrast support
Copilot Jun 13, 2025
b9a8adc
Update the background for the filter text in the main window.
brianrob Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/PerfView/MainWindow.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
<ColumnDefinition Width="Auto"/>
<ColumnDefinition Width="Auto"/>
</Grid.ColumnDefinitions>
<Menu Grid.Column="0" Background="{DynamicResource ControlDefaultBackground}" AutomationProperties.Name="Navigation">
<Menu Grid.Column="0" Background="{DynamicResource {x:Static SystemColors.MenuBarBrushKey}}" AutomationProperties.Name="Navigation">
<MenuItem Header="_File">
<MenuItem Header="_Clear Temp Files" Click="DoClearTempFiles" ToolTip="Some operations create temporary files. This command clears all of these."/>
<MenuItem Header="Clear User Config" Click="DoClearUserConfig" ToolTip="Reset all user preferences back to their defaults when PerfView was first installed."/>
Expand Down Expand Up @@ -149,7 +149,7 @@
<MenuItem Header="_About" Click="DoAbout"/>
</MenuItem>
</Menu>
<Rectangle Grid.Column="1" Grid.ColumnSpan="11" Fill="{DynamicResource ControlDefaultBackground}"/>
<Rectangle Grid.Column="1" Grid.ColumnSpan="11" Fill="{DynamicResource {x:Static SystemColors.MenuBarBrushKey}}"/>
<TextBlock Grid.Column="1" VerticalAlignment="Center" HorizontalAlignment="Center" Margin="3,0" TextWrapping="Wrap">
<Hyperlink Command="Help" CommandParameter="MainViewerQuickStart">Main View Help (F1)</Hyperlink>
</TextBlock>
Expand Down Expand Up @@ -186,7 +186,7 @@
<ColumnDefinition Width="Auto"/>
<ColumnDefinition Width="100*"/>
</Grid.ColumnDefinitions>
<Rectangle Grid.Column="0" Grid.ColumnSpan="3" Fill="{DynamicResource ControlDefaultBackground}"/>
<Rectangle Grid.Column="0" Grid.ColumnSpan="3" Fill="{DynamicResource {x:Static SystemColors.MenuBarBrushKey}}"/>
<TextBlock Grid.Column="0" VerticalAlignment="Center" Margin="5,0,0,0" ToolTip="Only files that match this RegEx filter pattern are displayed.">
<Hyperlink Command="Help" CommandParameter="FileFilterTextBox">Filter:</Hyperlink>
</TextBlock>
Expand Down