Fix TreeView auto-expansion when opening trace files#2218
Merged
Conversation
Co-authored-by: brianrob <6210322+brianrob@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Opening a Trace Does Not Expand the List of Options
Fix TreeView auto-expansion when opening trace files
May 30, 2025
Member
|
Copilot post-mortem:
|
marklio
approved these changes
Jun 4, 2025
Collaborator
marklio
left a comment
There was a problem hiding this comment.
I was initially annoyed that I had to go try to discover the same things that Copilot did in order to fix it, but I remembered I could look at the session and see what it learned. This was super-helpful in confirming that PerfViewTreeItem has the IsExpanded property backed with an INotifyPropertyChanged implementation that seemed wired-up correctly. Still, I wish Copilot had a summary that included the info "The tree view is backed by PerfViewTreeItem objects that have an IsExpanded property on them"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user double-clicks on a trace file in the main window, PerfView should automatically expand the first level of options for that trace file. However, the TreeView was not auto-expanding because the
IsExpandedproperty binding was missing from the TreeView's ItemContainerStyle.Root Cause
The data model (
PerfViewTreeItem) correctly setsIsExpanded = truewhen files are opened (inPerfViewData.cslines 535 and 10689), but the TreeView's ItemContainerStyle inMainWindow.xamlwas missing the binding to connect this property to the UI:Solution
Added the missing
IsExpandedproperty binding to the TreeView's ItemContainerStyle:This connects the data model's
IsExpandedproperty to the TreeViewItem'sIsExpandedproperty, enabling automatic expansion when trace files are opened.Change Impact
Fixes #2217.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.