Add graphviz into Dockerfile images for Python API documentation - #7819
Merged
Conversation
thiagocrepaldi
force-pushed
the
thiagofc/add-graphviz-dockerfile
branch
3 times, most recently
from
May 26, 2021 21:07
304b2e3 to
1398e3c
Compare
snnn
previously approved these changes
May 26, 2021
thiagocrepaldi
force-pushed
the
thiagofc/add-graphviz-dockerfile
branch
from
May 26, 2021 21:38
1398e3c to
7241354
Compare
snnn
reviewed
May 27, 2021
thiagocrepaldi
force-pushed
the
thiagofc/add-graphviz-dockerfile
branch
from
May 27, 2021 20:23
ee70212 to
ca15e8d
Compare
thiagocrepaldi
requested review from
BowenBao,
mrry and
spandantiwari
as code owners
May 27, 2021 20:23
thiagocrepaldi
force-pushed
the
thiagofc/add-graphviz-dockerfile
branch
4 times, most recently
from
June 1, 2021 20:33
da2567b to
93dbb8d
Compare
snnn
reviewed
Jun 1, 2021
snnn
reviewed
Jun 1, 2021
snnn
reviewed
Jun 1, 2021
added 8 commits
June 1, 2021 16:42
Needed by documentation generation pipelines
thiagocrepaldi
force-pushed
the
thiagofc/add-graphviz-dockerfile
branch
from
June 1, 2021 23:43
93dbb8d to
6ec4580
Compare
baijumeswani
previously approved these changes
Jun 2, 2021
baijumeswani
approved these changes
Jun 2, 2021
snnn
approved these changes
Jun 2, 2021
snnn
reviewed
Jun 3, 2021
| -e BUILD_BUILDNUMBER \ | ||
| onnxruntimecpubuild \ | ||
| bash /onnxruntime_src/tools/doc/builddoc.sh $(PythonManylinuxDir)/bin/ /onnxruntime_src /build Release | ||
| bash -c " $(PythonManylinuxDir)/bin/python3 -m pip install /build/Release/dist/onnxruntime*.whl && /onnxruntime_src/tools/doc/builddoc.sh $(PythonManylinuxDir)/bin/ /onnxruntime_src /build Release " ; |
Contributor
There was a problem hiding this comment.
If it is a nightly build, then the package name is ort_nightly or ort_gpu_nightly. onnxruntime*.whl doesn't match any.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/ci_build/github/azure-pipelines/templates/py-packaging-stage.yml requires graphviz, which is installed during Docker image creation
IMPORTANT numpy version was upgraded from 1.16 to 1.19 in this PR.
NOT IMPORTANT FOR RELEASE 1.8