[OpenVino] getcapability design by sfatimar · Pull Request #6863 · microsoft/onnxruntime

sfatimar · 2021-03-02T10:06:38Z

Redesign of get capability to ensure that we remove the redundant capability files for each ov version

Motivation and Context

This change is required to ensure that we follow a better design for getcapability
If it fixes an open issue, please link to the issue here.

…har/get_capability_design

change in data_ops.h for unsupported struct change in capability function to return the graph

…l/onnxruntime into sahar/get_capability_design

HectorSVC · 2021-03-02T17:49:38Z

/azp run Linux CPU CI Pipeline,Linux CPU x64 NoContribops CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,MacOS CI Pipeline,MacOS NoContribops CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline

HectorSVC · 2021-03-02T17:49:49Z

/azp run orttraining-linux-ci-pipeline,orttraining-mac-ci-pipeline,orttraining-linux-gpu-ci-pipeline,centos7_cpu,Linux CPU Minimal Build E2E CI Pipeline,Linux Nuphar CI Pipeline,MacOS NoContribops CI Pipeline,Linux OpenVINO CI Pipeline,orttraining-distributed

azure-pipelines · 2021-03-02T17:50:22Z

Azure Pipelines successfully started running 9 pipeline(s).

azure-pipelines · 2021-03-02T17:50:36Z

Azure Pipelines successfully started running 9 pipeline(s).

HectorSVC · 2021-03-02T18:04:14Z

/azp run orttraining-amd-gpu-ci-pipeline

azure-pipelines · 2021-03-02T18:04:23Z

Azure Pipelines successfully started running 1 pipeline(s).

HectorSVC · 2021-03-02T22:20:42Z

/azp run Linux CPU CI Pipeline

HectorSVC · 2021-03-03T00:46:47Z

@sfatimar, could you merge the latest master, the build failure looks wired.

sfatimar

@sfatimar, could you merge the latest master, the build failure looks wired.

Merged the master in

HectorSVC · 2021-03-03T17:41:27Z

/azp run Linux CPU CI Pipeline,Linux CPU x64 NoContribops CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,MacOS CI Pipeline,MacOS NoContribops CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline

HectorSVC · 2021-03-03T17:41:39Z

/azp run orttraining-linux-ci-pipeline,orttraining-mac-ci-pipeline,orttraining-linux-gpu-ci-pipeline,centos7_cpu,Linux CPU Minimal Build E2E CI Pipeline,Linux Nuphar CI Pipeline,MacOS NoContribops CI Pipeline,Linux OpenVINO CI Pipeline,orttraining-distributed, orttraining-amd-gpu-ci-pipeline

azure-pipelines · 2021-03-03T17:42:12Z

Azure Pipelines successfully started running 9 pipeline(s).

azure-pipelines · 2021-03-03T17:42:25Z

Azure Pipelines successfully started running 10 pipeline(s).

HectorSVC · 2021-03-04T06:10:08Z

@sfatimar There are some failed tests, please take a look.
1: [ FAILED ] ModelTests/ModelTest.Run/446, where GetParam() = "openvino_../models/opset7/keras2coreml_BiDirectional_ImageNet/model.onnx"
1: [ FAILED ] ModelTests/ModelTest.Run/753, where GetParam() = "openvino_../models/opset9/test_GPT2/model.onnx"
1: [ FAILED ] ModelTests/ModelTest.Run/777, where GetParam() = "openvino_../models/opset10/GPT2/model.onnx"

sfatimar · 2021-03-08T18:28:32Z

@HectorSVC I am still not able to root cause this issue. When I run my build in internal CI I am not able to run the ModelTests.
When I try to run the gpt2 models from opset 10 and 11 repo I am not facing any issues with onnx_test_runner.
Will appreciate your help in this matter. Is there some way I can access these models and run them myself.

HectorSVC · 2021-03-11T18:26:41Z

/azp run Linux CPU CI Pipeline,Linux CPU x64 NoContribops CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,MacOS CI Pipeline,MacOS NoContribops CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline

HectorSVC · 2021-03-11T18:26:51Z

/azp run orttraining-linux-ci-pipeline,orttraining-mac-ci-pipeline,orttraining-linux-gpu-ci-pipeline,centos7_cpu,Linux CPU Minimal Build E2E CI Pipeline,Linux Nuphar CI Pipeline,MacOS NoContribops CI Pipeline,Linux OpenVINO CI Pipeline,orttraining-distributed, orttraining-amd-gpu-ci-pipeline

azure-pipelines · 2021-03-11T18:27:24Z

Azure Pipelines successfully started running 9 pipeline(s).

azure-pipelines · 2021-03-11T18:27:42Z

Azure Pipelines successfully started running 10 pipeline(s).

HectorSVC · 2021-03-11T22:58:24Z

1: [ FAILED ] 1 test, listed below:
1: [ FAILED ] ModelTests/ModelTest.Run/446, where GetParam() = "openvino_../models/opset7/keras2coreml_BiDirectional_ImageNet/model.onnx"
1:
1: 1 FAILED TEST
1: YOU HAVE 4 DISABLED TESTS
1:
1/6 Test #1: onnxruntime_test_all ...................***Failed 1617.48 sec

HectorSVC · 2021-03-11T23:01:27Z

/azp run Linux OpenVINO CI Pipeline

azure-pipelines · 2021-03-11T23:01:41Z

Azure Pipelines successfully started running 1 pipeline(s).

sfatimar · 2021-03-12T07:23:43Z

Resolved build issues

HectorSVC · 2021-03-12T16:16:41Z

/azp run Linux OpenVINO CI Pipeline

azure-pipelines · 2021-03-12T16:16:51Z

Azure Pipelines successfully started running 1 pipeline(s).

HectorSVC · 2021-03-12T17:14:24Z

/azp run Linux CPU CI Pipeline,Linux CPU x64 NoContribops CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,MacOS CI Pipeline,MacOS NoContribops CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline

HectorSVC · 2021-03-12T17:14:51Z

/azp run orttraining-linux-ci-pipeline,orttraining-mac-ci-pipeline,orttraining-linux-gpu-ci-pipeline,centos7_cpu,Linux CPU Minimal Build E2E CI Pipeline,Linux Nuphar CI Pipeline,MacOS NoContribops CI Pipeline,orttraining-distributed, orttraining-amd-gpu-ci-pipeline

azure-pipelines · 2021-03-12T17:15:08Z

Azure Pipelines successfully started running 9 pipeline(s).

azure-pipelines · 2021-03-12T17:15:36Z

Azure Pipelines successfully started running 8 pipeline(s).

HectorSVC

sfatimar and others added 17 commits January 25, 2021 15:36

get capability design update

3e7dc91

get capability design changed

26e7514

Merge branch 'master' of https://github.com/intel/onnxruntime into sa…

f7cfbca

…har/get_capability_design

changes in comments

901b777

change in data_ops.h for unsupported struct change in capability function to return the graph

some small change error

fbab353

MaxPool condition added

3840e44

MaxPool element type supported

8ff4e4a

upsample not applicable for gpu

6c690cd

get capability design update

613aa02

get capability design changed

e4a35f9

changes in comments

2eec738

change in data_ops.h for unsupported struct change in capability function to return the graph

some small change error

07b5d48

MaxPool condition added

2d45b1e

MaxPool element type supported

13421a8

upsample not applicable for gpu

b148955

Merge branch 'sahar/get_capability_design' of https://github.com/inte…

9112ba3

…l/onnxruntime into sahar/get_capability_design

porting issue with maxpool and averagepool dimension support

aa87155

sfatimar requested a review from a team as a code owner March 2, 2021 10:06

HectorSVC requested a review from jywu-mysoft March 2, 2021 17:50

HectorSVC changed the title ~~Sahar/get capability design~~ [OpenVino] getcapability design Mar 2, 2021

HectorSVC reviewed Mar 2, 2021

View reviewed changes

Comment thread onnxruntime/core/providers/openvino/ov_versions/capabilities.h

sfatimar added 2 commits March 2, 2021 23:41

dimension supported for average pool

76d638f

Removed the extra capability files

801bac0

sfatimar and others added 2 commits March 3, 2021 13:20

get_capability_design

12faa34

Merge branch 'master' into sahar/get_capability_design

61478fe

sfatimar commented Mar 3, 2021

View reviewed changes

Comment thread onnxruntime/core/providers/openvino/ov_versions/capabilities.h

Commit message to fix slice errors

7991480

commit for fixing the keras_2convertmodel

37d738e

HectorSVC approved these changes Mar 12, 2021

View reviewed changes

HectorSVC merged commit 4c9ccb0 into microsoft:master Mar 12, 2021

Merge branch 'master' into sahar/get_capability_design

a1ab640

preetha-intel deleted the sahar/get_capability_design branch December 29, 2022 08:53

Uh oh!

Conversation

sfatimar commented Mar 2, 2021

Uh oh!

HectorSVC commented Mar 2, 2021

Uh oh!

HectorSVC commented Mar 2, 2021

Uh oh!

azure-pipelines Bot commented Mar 2, 2021

Uh oh!

azure-pipelines Bot commented Mar 2, 2021

Uh oh!

Uh oh!

HectorSVC commented Mar 2, 2021

Uh oh!

azure-pipelines Bot commented Mar 2, 2021

Uh oh!

HectorSVC commented Mar 2, 2021

Uh oh!

HectorSVC commented Mar 3, 2021

Uh oh!

sfatimar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

HectorSVC commented Mar 3, 2021

Uh oh!

HectorSVC commented Mar 3, 2021

Uh oh!

azure-pipelines Bot commented Mar 3, 2021

Uh oh!

azure-pipelines Bot commented Mar 3, 2021

Uh oh!

HectorSVC commented Mar 4, 2021

Uh oh!

sfatimar commented Mar 8, 2021

Uh oh!

HectorSVC commented Mar 11, 2021

Uh oh!

HectorSVC commented Mar 11, 2021

Uh oh!

azure-pipelines Bot commented Mar 11, 2021

Uh oh!

azure-pipelines Bot commented Mar 11, 2021

Uh oh!

HectorSVC commented Mar 11, 2021

Uh oh!

HectorSVC commented Mar 11, 2021

Uh oh!

azure-pipelines Bot commented Mar 11, 2021

Uh oh!

sfatimar commented Mar 12, 2021

Uh oh!

HectorSVC commented Mar 12, 2021

Uh oh!

azure-pipelines Bot commented Mar 12, 2021

Uh oh!

HectorSVC commented Mar 12, 2021

Uh oh!

HectorSVC commented Mar 12, 2021

Uh oh!

azure-pipelines Bot commented Mar 12, 2021

Uh oh!

azure-pipelines Bot commented Mar 12, 2021

Uh oh!

HectorSVC left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants