Skip to content

Allow sharing of initializers between sessions. - #5092

Merged
pranavsharma merged 12 commits into
masterfrom
share_weights
Sep 21, 2020
Merged

Allow sharing of initializers between sessions.#5092
pranavsharma merged 12 commits into
masterfrom
share_weights

Conversation

@pranavsharma

@pranavsharma pranavsharma commented Sep 9, 2020

Copy link
Copy Markdown
Contributor

Description: Allow sharing of initializers between sessions.
NB: This is not intended for 1.5 release.

Motivation and Context
LUIS team produces many models that share the initializers. They would like the ability to share them across sessions for efficiency. They've tested the changes e2e.
Design: https://microsoft-my.sharepoint.com/:w:/p/prs/EUi_AfiH5RNMtkO3up6hndYBoICNa4GWyu9Mp7It8k-Yzw?e=xVfF5L

@pranavsharma
pranavsharma requested a review from a team as a code owner September 9, 2020 07:25
Comment thread docs/C_API.md Outdated
Comment thread onnxruntime/test/shared_lib/test_inference.cc
Comment thread onnxruntime/test/shared_lib/test_inference.cc
Comment thread onnxruntime/test/shared_lib/test_inference.cc
Comment thread onnxruntime/test/shared_lib/test_inference.cc
Comment thread include/onnxruntime/core/session/onnxruntime_cxx_api.h Outdated
Comment thread onnxruntime/core/session/abi_session_options.cc Outdated
Comment thread onnxruntime/core/session/abi_session_options.cc
RandySheriffH
RandySheriffH previously approved these changes Sep 10, 2020
Comment thread include/onnxruntime/core/session/onnxruntime_c_api.h
Comment thread onnxruntime/core/session/abi_session_options.cc Outdated
Comment thread onnxruntime/core/framework/session_options.h
Comment thread onnxruntime/test/framework/inference_session_test.cc
Moved AddInitializer logic to internal session options
Added tests for owned buffer
Clarified documentation
Fix bug where memory info and not device was getting compared
@pranavsharma pranavsharma changed the title [WIP] Allow sharing of initializers between sessions. Allow sharing of initializers between sessions. Sep 17, 2020
snnn
snnn previously approved these changes Sep 19, 2020
Comment thread onnxruntime/core/framework/session_state_utils.cc
Comment thread include/onnxruntime/core/session/onnxruntime_c_api.h
Comment thread include/onnxruntime/core/session/onnxruntime_c_api.h
Comment thread docs/C_API.md
Comment thread onnxruntime/core/session/onnxruntime_c_api.cc

@skottmckay skottmckay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants