Fix TensorScatter CPU security issue - #29916
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a CPU-side safety/security issue in the ONNX TensorScatter operator by restricting kernel registration to fixed-size tensor element types, preventing unsafe raw-buffer operations on non-fixed-size types (e.g., string). It also adds a unit test to validate that string-typed graphs are rejected during kernel resolution.
Changes:
- Restrict the CPU
TensorScatterkernel type constraint fromAllTensorTypes()toAllFixedSizeTensorTypes(). - Add a CPU-only unit test covering
stringinputs and expecting graph resolution to fail.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| onnxruntime/core/providers/cpu/llm/tensorscatter.cc | Tightens the CPU kernel type constraint to fixed-size tensor element types to avoid unsafe raw-memory operations on strings. |
| onnxruntime/test/providers/cpu/llm/tensorscatter_op_test.cc | Adds a regression test that attempts to bind tensor(string) to TensorScatter and expects kernel resolution to fail. |
nenad1002
enabled auto-merge (squash)
July 28, 2026 18:36
…ernel-lookup paths pass
tianleiwu
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix TensorScatter CPU security issue
Motivation and Context