Fix out-of-bounds error - #28991
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the CPU transformers generation logits processing code against out-of-bounds access by validating token IDs against the vocabulary size before indexing into per-beam score buffers.
Changes:
- Added token-id bounds checks in
RepetitionPenaltyLogitsProcessor<T>::Processbefore reading/writingbeam_token_scores. - Added token-id bounds checks in
NoRepeatNGramLogitsProcessor<T>::Processbefore writingbeam_token_scores. - Changed
NextTokenScores::SetScoreto safely return on invalidtoken_idinstead of asserting.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| onnxruntime/contrib_ops/cpu/transformers/logits_processor.h | Makes NextTokenScores::SetScore resilient to invalid token IDs to avoid OOB writes. |
| onnxruntime/contrib_ops/cpu/transformers/logits_processor.cc | Prevents OOB access in repetition-penalty and no-repeat-ngram processors by skipping invalid IDs. |
tianleiwu
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces important safety checks to prevent out-of-bounds access in the logits processing code for transformers. The main updates ensure that token IDs are validated against the vocabulary size before being used, which improves robustness and prevents potential crashes.
Safety and robustness improvements:
RepetitionPenaltyLogitsProcessor<T>::Processmethod to ensure only valid IDs are used when accessingbeam_token_scores.NoRepeatNGramLogitsProcessor<T>::Processmethod to prevent out-of-bounds writes tobeam_token_scores.NextTokenScores::SetScoremethod to return early if the providedtoken_idis out of bounds, replacing the previous assert with a safe check.