rev some npm packages - #28547
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates JavaScript/TypeScript code and package configurations, primarily to accommodate newer typings/runtime expectations and to bump/override several npm dependencies.
Changes:
- Adjusted multiple WASM/JSEP/WebGPU/WebNN code paths with stricter type assertions/casts (ArrayBuffer, Float16Array, GPUFeatureName, etc.).
- Updated several
package.jsonfiles with new dependency versions and addedoverrides. - Performed formatting/typing cleanups across shared TS interfaces and test utilities.
Reviewed changes
Copilot reviewed 26 out of 34 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| js/web/test/test-runner.ts | Tweaks File construction typing for generated model download. |
| js/web/test/e2e/exports/testcases/nextjs-default/package.json | Updates Next/React deps and adds a PostCSS override for the e2e testcase. |
| js/web/package.json | Adds ws override. |
| js/web/lib/wasm/wasm-types.ts | Flattens interface extends formatting. |
| js/web/lib/wasm/wasm-factory.ts | Adds an ArrayBuffer assertion for wasmBinary assignment. |
| js/web/lib/wasm/wasm-core-impl.ts | Minor typing adjustments for ML tensor handling and dims passing. |
| js/web/lib/wasm/wasm-common.ts | Removes Float16Array global polyfill declaration and adjusts float16 typed-array selection. |
| js/web/lib/wasm/proxy-worker/main.ts | Removes message casts when postMessage-ing results/errors. |
| js/web/lib/wasm/jsep/webnn/tensor-manager.ts | Adds ArrayBuffer assertions around typed-array buffer usage/returns. |
| js/web/lib/wasm/jsep/webgpu/program-manager.ts | Removes GPUFeatureName cast for subgroups. |
| js/web/lib/wasm/jsep/webgpu/ops/resize.ts | Fixes Uint32Array construction to use the underlying ArrayBuffer. |
| js/web/lib/wasm/jsep/webgpu/ops/attention.ts | Removes unnecessary import and simplifies uniform type. |
| js/web/lib/wasm/jsep/backend-webnn.ts | Simplifies Float16Array runtime check when creating views. |
| js/web/lib/wasm/jsep/backend-webgpu.ts | Removes GPUFeatureName cast; changes adapter info acquisition; asserts ArrayBuffer on downloaded data. |
| js/react_native/package.json | Adds fast-xml-parser override. |
| js/react_native/lib/binding.ts | Removes inline eslint disable in global OrtApi declaration. |
| js/react_native/e2e/package.json | Adds overrides for fast-xml-parser and cross-spawn. |
| js/package.json | Adds overrides for diff and serialize-javascript. |
| js/node/test/test-utils.ts | Ensures protobuf decode receives a Uint8Array rather than a Node Buffer. |
| js/node/package.json | Bumps @types/node to a newer major line. |
| js/node/lib/backend.ts | Asserts ArrayBuffer for native session loadModel buffer input. |
| js/common/lib/tensor-factory.ts | Formatting of interface extends clauses and type parameter list. |
| js/common/lib/tensor-factory-impl.ts | Flattens extends list formatting. |
| js/common/lib/inference-session.ts | Formatting of interface extends clause. |
| js/common/lib/env-impl.ts | Removes type assertion on env.wasm initialization. |
| js/README.md | Removes stray blank lines in setup/build docs. |
Files not reviewed (4)
- js/common/package-lock.json: Language not supported
- js/node/package-lock.json: Language not supported
- js/web/test/e2e/exports/testcases/nextjs-default/package-lock.json: Language not supported
- js/web/test/e2e/type/testcases/module-resolution/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
js/web/test/e2e/exports/testcases/nextjs-default/package.json:1
- For an E2E testcase, using
^ranges for core framework packages and overrides can introduce non-determinism (different installs over time may pull different minor/patch versions). Consider pinning exact versions for the testcase (and thepostcssoverride) to stabilize CI runs and make regressions easier to reproduce.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@copilot apply changes based on the comments in this thread |
Copilot stopped work on behalf of
guschmue due to an error
May 19, 2026 22:33
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This reverts commit 08f2531.
prathikr
reviewed
May 21, 2026
prathikr
reviewed
May 21, 2026
prathikr
reviewed
May 21, 2026
edgchen1
reviewed
May 21, 2026
guschmue
enabled auto-merge (squash)
May 22, 2026 18:00
prathikr
approved these changes
May 26, 2026
mustjab
added a commit
that referenced
this pull request
Jul 28, 2026
…29926) ## Description Updates vulnerable dev/test npm dependencies in the `nextjs-default` export e2e fixture lockfile. Follow-up to #29827, which covered the other five lockfiles but not this one. ## Updates - `next` `15.5.18` -> `15.5.22` - `postcss` `8.5.14` -> `8.5.24` - `nanoid` `3.3.12` -> `3.3.16` Modified lockfile: - `js/web/test/e2e/exports/testcases/nextjs-default/package-lock.json` `next` 15.5.18 predates the `15.5.21` security release co-published with `16.2.11`, so the fixture still resolved to a version affected by the CVE-2026-64641..64649 advisory batch. `postcss` 8.5.14 is likewise inside the affected range (`<= 8.5.17`) for CVE-2026-45623. Note the fixture intentionally tracks the `15.x` line (`next: ^15.0.0` in package.json, per #28547), so `15.5.22` — not `16.2.11` — is the correct target. No package manifests or runtime source files are changed. The resolved dependency set is unchanged (identical package keys before/after); the diff is purely `version`/`resolved`/`integrity`. ## Validation - Regenerated with `npm audit fix --package-lock-only` against `registry.npmjs.org`; verified zero `resolved` URLs point anywhere else. - `npm audit --package-lock-only` no longer reports `next` or `postcss` advisories; the diff is a balanced 46 insertions / 46 deletions. - Confirmed package key sets are identical pre/post, so no dependency was added or dropped. - Preserved `libc` metadata that npm >= 11.6 drops when rewriting lockfiles (the packages still declare it), keeping musl/glibc optional-dep selection intact for the `@next/swc-linux-*` binaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rev some npm packages