Skip to content

fix lint errors in js pipeline - #26938

Closed
prathikr wants to merge 9 commits into
mainfrom
prathikrao/js-lint-warn
Closed

fix lint errors in js pipeline#26938
prathikr wants to merge 9 commits into
mainfrom
prathikrao/js-lint-warn

Conversation

@prathikr

@prathikr prathikr commented Jan 8, 2026

Copy link
Copy Markdown
Contributor
  • suppresses errors related to uncessary type assertions only where it is creating noise for the pipelines
  • resolves [baseline-browser-mapping] The data in this module is over two months old. To ensure accurate Baseline data, please update: npm i baseline-browser-mapping@latest -D by running the recommended update

Comment thread js/eslint.config.mjs Outdated
@prathikr prathikr changed the title adjust lint to allow extra type assertions for stronger typed code fix lint errors in js pipeline Jan 8, 2026
@prathikr
prathikr requested review from edgchen1 and fs-eire January 8, 2026 18:31
@fs-eire

fs-eire commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

I think this is incorrectly setup. without any of the change in this PR, the npm run lint under folder /js/ does not report any problem. (this is performed in the web CI pipeline)

I think the lint CI pipeline does not respect the typescript project file so that it generates the wrong result.

@prathikr

prathikr commented Jan 8, 2026

Copy link
Copy Markdown
Contributor Author

I think this is incorrectly setup. without any of the change in this PR, the npm run lint under folder /js/ does not report any problem. (this is performed in the web CI pipeline)

I think the lint CI pipeline does not respect the typescript project file so that it generates the wrong result.

I can repro the issue locally...

image

@fs-eire

fs-eire commented Jan 9, 2026

Copy link
Copy Markdown
Contributor

do you still see the error when doing this:

  • run npm ci in /js/
  • run npm ci in /js/common/
  • run npm ci in /js/web/
  • run npm run lint in /js/

@prathikr

prathikr commented Jan 9, 2026

Copy link
Copy Markdown
Contributor Author

do you still see the error when doing this:

  • run npm ci in /js/
  • run npm ci in /js/common/
  • run npm ci in /js/web/
  • run npm run lint in /js/

No, now there is no error. Is this what should be done in the pipeline?

@fs-eire

fs-eire commented Jan 10, 2026

Copy link
Copy Markdown
Contributor

I think we can probably ignore the /js/ folder in the Lint, since it is already covered in the Web CI pipeline

@prathikr

Copy link
Copy Markdown
Contributor Author

Looks like the lint javascript job only operates on the /js/ folder, should we just remove this stage entirely? link

@prathikr

Copy link
Copy Markdown
Contributor Author

Continued in #26984

@prathikr prathikr closed this Jan 12, 2026
This reverts commit eca4142.
@prathikr prathikr reopened this Jan 12, 2026
@prathikr
prathikr requested a review from guschmue January 12, 2026 20:40
@prathikr prathikr closed this Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants