coreml: Fix Gather fp16 support - #26442
Merged
Merged
Conversation
Contributor
Author
|
Is anything else needed for this? |
Contributor
Author
|
Should I merge with master to pick f49ae6f? |
Contributor
Author
|
@snnn is there anything else needed for this? |
Contributor
Author
|
Ping |
Contributor
Author
|
@edgchen1 or @snnn can you please take a look? This is a one-liner that just adds documented support for fp16 to |
edgchen1
reviewed
Dec 20, 2025
edgchen1
reviewed
Dec 20, 2025
Contributor
Author
|
Is this OK now? |
edgchen1
reviewed
Jan 9, 2026
edgchen1
approved these changes
Jan 9, 2026
Contributor
|
/azp run Linux QNN CI Pipeline,Windows ARM64 QNN CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Windows GPU Doc Gen CI Pipeline |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Contributor
|
thanks for the contribution! |
alex-spacemit
pushed a commit
to spacemit-com/onnxruntime
that referenced
this pull request
Jan 20, 2026
### Description <!-- Describe your changes. --> The coreml gather MLProgram operator supports fp16, but the check was missing in `GatherOpBuilder::HasSupportedInputsImpl()` ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> We use `Gather` in LeelaChessZero. --------- Co-authored-by: borg323 <borg323@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The coreml gather MLProgram operator supports fp16, but the check was missing in
GatherOpBuilder::HasSupportedInputsImpl()Motivation and Context
We use
Gatherin LeelaChessZero.