[Natvis] Improve InlinedVector rendering - #26124
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the Natvis debugging visualization for Abseil's InlinedVector class and cleans up stale code. The changes enhance debugging experience by providing more detailed metadata display and better handling of different template parameter configurations.
- Split InlinedVector Natvis definitions to handle both 2-parameter and 3-parameter template forms
- Enhanced display strings and metadata items with capacity, storage type, and diagnostic information
- Removed obsolete Storage and map_slot_type Natvis definitions
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
snnn
approved these changes
Sep 22, 2025
snnn
left a comment
Contributor
There was a problem hiding this comment.
Thanks for keeping it up to date.
fs-eire
pushed a commit
that referenced
this pull request
Oct 24, 2025
### Description <!-- Describe your changes. --> Improve InlinedVector Remove stale raw_hash_set
naomiOvad
pushed a commit
to naomiOvad/onnxruntime
that referenced
this pull request
Nov 2, 2025
### Description <!-- Describe your changes. --> Improve InlinedVector Remove stale raw_hash_set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve InlinedVector
Remove stale raw_hash_set