Skip to content

Add Windows ARM64 I8MM detection. - #24563

Merged
jywu-mysoft merged 8 commits into
mainfrom
edgchen1/win_arm64_detect_i8mm
Apr 29, 2025
Merged

Add Windows ARM64 I8MM detection.#24563
jywu-mysoft merged 8 commits into
mainfrom
edgchen1/win_arm64_detect_i8mm

Conversation

@edgchen1

@edgchen1 edgchen1 commented Apr 26, 2025

Copy link
Copy Markdown
Contributor

Description

Add some logic to detect whether I8MM is actually supported.

This info can be read from the registry. See the helpful comments here for more details:
https://github.com/Dr-Noob/cpufetch/blob/a0c08ccc0b64b524ad2122e0595099f73cbba9c4/src/arm/midr.c#L30-L52

Motivation and Context

Detect I8MM correctly to enable better performance.

@edgchen1
edgchen1 requested a review from snnn April 26, 2025 00:57

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

Comment thread onnxruntime/core/common/cpuid_info.cc
edgchen1 and others added 3 commits April 25, 2025 18:01
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…/onnxruntime into edgchen1/win_arm64_detect_i8mm
@snnn

snnn commented Apr 26, 2025

Copy link
Copy Markdown
Contributor

/azp run Windows ARM64 QNN CI Pipeline, Big Models

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@jywu-mysoft
jywu-mysoft merged commit a9a3ad2 into main Apr 29, 2025
@jywu-mysoft
jywu-mysoft deleted the edgchen1/win_arm64_detect_i8mm branch April 29, 2025 07:25
vraspar pushed a commit that referenced this pull request May 1, 2025
### Description
<!-- Describe your changes. -->

Add some logic to detect whether I8MM is actually supported.

This info can be read from the registry. See the helpful comments here
for more details:

https://github.com/Dr-Noob/cpufetch/blob/a0c08ccc0b64b524ad2122e0595099f73cbba9c4/src/arm/midr.c#L30-L52

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->

Detect I8MM correctly to enable better performance.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jywu-mysoft pushed a commit that referenced this pull request May 1, 2025
### Description

Cherry pick the following into
[rel-1.22.0](https://github.com/microsoft/onnxruntime/tree/rel-1.22.0)

- (#24491)
- (#24509)
- (#24564)
- (#24574)
- (#24582)
- (#24584)
- (#24568)
- (#24587)
- (#24563)
- (#24592)
- (#24526)
- (#24552)
- (#24588)
- (#24605)
- (#24606)

---------

Co-authored-by: Jing Fang <126209182+fajin-corp@users.noreply.github.com>
Co-authored-by: Tianlei Wu <tlwu@microsoft.com>
Co-authored-by: Baiju Meswani <bmeswani@microsoft.com>
Co-authored-by: Scott McKay <skottmckay@gmail.com>
Co-authored-by: Mark Schofield <mschofie@microsoft.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Edward Chen <18449977+edgchen1@users.noreply.github.com>
Co-authored-by: Ashwath Shankarnarayan <quic_ashwshan@quicinc.com>
Co-authored-by: saurabh <saurabh1.kale@intel.com>
Co-authored-by: Adrian Lizarraga <adlizarraga@microsoft.com>
Co-authored-by: Hector Li <hecli@microsoft.com>
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request May 12, 2025
### Description
<!-- Describe your changes. -->

Add some logic to detect whether I8MM is actually supported.

This info can be read from the registry. See the helpful comments here
for more details:

https://github.com/Dr-Noob/cpufetch/blob/a0c08ccc0b64b524ad2122e0595099f73cbba9c4/src/arm/midr.c#L30-L52

### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->

Detect I8MM correctly to enable better performance.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@snnn

snnn commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

This PR has been included in the rel-1.22.0 branch. Removing the release:1.22.0 label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants