Fix #24130 by adding an empty dependency group to the code that generates Microsoft.ML.OnnxRuntime.nuspec - #24131
Conversation
|
/azp run Big Models, Linux Android Emulator QNN CI Pipeline, Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline |
|
/azp run Linux OpenVINO CI Pipeline, Linux QNN CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, Win_TRT_Minimal_CUDA_Test_CI, Windows ARM64 QNN CI Pipeline, Windows GPU Doc Gen CI Pipeline, Windows x64 QNN CI Pipeline |
|
Azure Pipelines successfully started running 6 pipeline(s). |
|
Azure Pipelines successfully started running 8 pipeline(s). |
|
I think this is ready to merge. |
|
@snnn Can we get this PR merged please? I'd really like it to get in to the next release, when that happens. Thanks! |
|
Sorry I was OOF last week. Brought my kids for a family trip. |
|
No worries, I was off for spring break with my 1-year-old too :) |
…hat generates Microsoft.ML.OnnxRuntime.nuspec (microsoft#24131) ### Description As detailed in the issue (microsoft#24130), the Microsoft.ML.OnnxRuntime nuspec needs an additional dependency group for the `native` TFM, to allow it to be referenced via `PackageReference` in vcxproj projects. I took a peek at the code after filing the issue, since it seemed like it ought to be a simple fix. It looks like the nuspec file for the `Microsoft.ML.OnnxRuntime` package is generated by the python code in `generate_nuspec_for_native_nuget.py`, so I just added a line of code there. However I'm not sure how the build system invokes this generator so I haven't been able to test it in situ. Let me know if this isn't the right fix! ### Motivation and Context See detailed description in microsoft#24130 Signed-off-by: bfilipek <bartlomiej.filipek@intel.com>
|
Do you have a rough idea when I should expect this fix to make it to a RTM version of the package? Looks like it didn't make it into the |
Description
As detailed in the issue (#24130), the Microsoft.ML.OnnxRuntime nuspec needs an additional dependency group for the
nativeTFM, to allow it to be referenced viaPackageReferencein vcxproj projects.I took a peek at the code after filing the issue, since it seemed like it ought to be a simple fix. It looks like the nuspec file for the
Microsoft.ML.OnnxRuntimepackage is generated by the python code ingenerate_nuspec_for_native_nuget.py, so I just added a line of code there.However I'm not sure how the build system invokes this generator so I haven't been able to test it in situ. Let me know if this isn't the right fix!
Motivation and Context
See detailed description in #24130