[WIP][webgpu] Apply dp4a for generation shader - #23585
Closed
qjia7 wants to merge 13 commits into
Closed
Conversation
qjia7
force-pushed
the
matmulnbits-generation
branch
from
February 8, 2025 02:21
6b5f15e to
bcb37fe
Compare
Contributor
Author
|
Replaced by #24064 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr applies DP4A to generation shader. It uses similar ideas compared with previous generation shader, but different data types.
In easy mode: NV 42 tokens/s -> 45 tokens/s, Meteor Lake 19 tokens/s -> 20 tokens/s
Without this PR
NV
Meteor Lake
With this PR
NV
Meteor Lake