Skip to content

[onnxruntime/build] Add new flag enable_generic_interface to build primary EPs by default - #23342

Merged
karim-vad merged 26 commits into
mainfrom
dev/kvadsariya/wcr
Jan 28, 2025
Merged

[onnxruntime/build] Add new flag enable_generic_interface to build primary EPs by default#23342
karim-vad merged 26 commits into
mainfrom
dev/kvadsariya/wcr

Conversation

@karim-vad

Copy link
Copy Markdown
Contributor

Description

  • Add new build flag in build.py to build onnxruntime.dll supporting interfaces for all primary EPs( QNN, TensoRT, OpenVino, VitisAI).
  • Modify onnxruntime.dll/onnxruntime_shared.dll build settings to remove dependency of IHV SDK Toolset to be installed on the system.
  • Change CMake variables to be explicit when building EP vs ORT. e.g. onnxruntime_USE_TENSORRT vs onnxruntime_USE_TENSORRT_INTERFACE, to evolve the build system to build ORT independent of EPs.

Motivation and Context

Changes in the build system required to evolve the repo to build the components independently while removing unnecessary dependencies

Comment thread samples/GenericInterface/test.cpp Fixed
Comment thread tools/ci_build/build.py Fixed
Comment thread tools/ci_build/build.py Fixed
Comment thread tools/ci_build/build.py Outdated
Comment thread onnxruntime/core/session/provider_bridge_ort.cc Fixed
Comment thread onnxruntime/core/session/provider_bridge_ort.cc Fixed
Comment thread tools/ci_build/build.py Outdated
Comment thread tools/ci_build/build.py
Comment thread samples/GenericInterface/test.cpp Outdated
@jslhcl
jslhcl marked this pull request as draft January 13, 2025 22:05
Comment thread tools/ci_build/build.py Fixed
Comment thread onnxruntime/core/session/provider_bridge_ort.cc Fixed
Comment thread onnxruntime/core/session/provider_bridge_ort.cc Fixed
@karim-vad
karim-vad marked this pull request as ready for review January 15, 2025 18:16
Comment thread cmake/CMakeLists.txt
Comment thread tools/ci_build/build.py
Comment thread tools/ci_build/build.py Outdated
Comment thread cmake/external/onnxruntime_external_deps.cmake Outdated
Comment thread samples/GenericInterface/CMakeLists.txt Outdated
Comment thread samples/GenericInterface/test.cpp Outdated
snnn
snnn previously approved these changes Jan 22, 2025
Comment thread cmake/onnxruntime_providers.cmake
Comment thread onnxruntime/core/session/provider_bridge_ort.cc
Comment thread onnxruntime/core/providers/shared_library/provider_interfaces.h Fixed
Comment thread onnxruntime/core/providers/shared_library/provider_interfaces.h Fixed
Comment thread onnxruntime/core/providers/shared_library/provider_interfaces.h Fixed
Comment thread onnxruntime/core/providers/shared_library/provider_interfaces.h Fixed
Comment thread onnxruntime/core/session/provider_bridge_ort.cc Fixed
Comment thread onnxruntime/core/session/provider_bridge_ort.cc Fixed
Comment thread tools/ci_build/build.py Outdated
Comment thread tools/ci_build/build.py Outdated
Comment thread onnxruntime/core/session/provider_bridge_ort.cc
snnn
snnn previously approved these changes Jan 23, 2025
Comment thread tools/ci_build/build.py

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

Comment thread tools/ci_build/build.py
karim-vad and others added 2 commits January 23, 2025 23:38
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@karim-vad

karim-vad commented Jan 28, 2025 via email

Copy link
Copy Markdown
Contributor Author

@snnn snnn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@karim-vad
karim-vad merged commit 655a23f into main Jan 28, 2025
@karim-vad
karim-vad deleted the dev/kvadsariya/wcr branch January 28, 2025 23:24
@adrianlizarraga

Copy link
Copy Markdown
Contributor

@karim-vad Thank you!

ashrit-ms pushed a commit that referenced this pull request Feb 11, 2025
…imary EPs by default (#23342)

### Description
- Add new build flag in build.py to build onnxruntime.dll supporting
interfaces for all primary EPs( QNN, TensoRT, OpenVino, VitisAI).
- Modify onnxruntime.dll/onnxruntime_shared.dll build settings to remove
dependency of IHV SDK Toolset to be installed on the system.
- Change CMake variables to be explicit when building EP vs ORT. e.g.
onnxruntime_USE_TENSORRT vs onnxruntime_USE_TENSORRT_INTERFACE, to
evolve the build system to build ORT independent of EPs.



### Motivation and Context
Changes in the build system required to evolve the repo to build the
components independently while removing unnecessary dependencies

---------

Co-authored-by: Lei Cao <jslhcl@gmail.com>
Co-authored-by: Karim Vadsariya <kvadsariya@microsoft.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants