Add CumSum and Round for Opset 11 - #1705
Merged
Merged
Conversation
Contributor
askhade
reviewed
Aug 28, 2019
askhade
reviewed
Aug 28, 2019
jiafatom
reviewed
Aug 28, 2019
| Status Round<MLFloat16>::Compute(OpKernelContext* ctx) const { | ||
| const auto& X = *ctx->Input<Tensor>(0); | ||
| auto& Y = *ctx->Output(0, X.Shape()); | ||
| auto input = X.template Data<MLFloat16>(); |
Contributor
There was a problem hiding this comment.
There are several places (other than this line) where RHS is of type ptr and LHS is just auto. As per the coding guidelines we should "Qualify usages of 'auto' with 'const', '*', '&' and '&&' where applicable to more clearly express the intent".
Contributor
Author
There was a problem hiding this comment.
Updated in the other locations as well, to make it more clear which auto vars are consts and pointers.
pranavsharma
approved these changes
Sep 26, 2019
| WritableSliceIterator(Tensor& tensor, const TensorShape& tensor_shape, gsl::span<const int64_t> starts, | ||
| gsl::span<const int64_t> extents, gsl::span<const int64_t> steps) | ||
| : tensor_(tensor), input_(tensor_.template MutableData<T>()), extents_(extents), skips_(tensor_shape, extents, steps), indices_(extents.size(), 0) { | ||
| auto& dims = tensor_shape.GetDims(); |
| WritableSliceIterator(Tensor& tensor, gsl::span<const int64_t> starts, | ||
| gsl::span<const int64_t> extents, gsl::span<const int64_t> steps) | ||
| : tensor_(tensor), input_(tensor_.template MutableData<T>()), extents_(extents), skips_(tensor_.Shape(), extents, steps), indices_(extents.size(), 0) { | ||
| auto& dims = tensor_.Shape().GetDims(); |
yuslepukhin
pushed a commit
that referenced
this pull request
Mar 17, 2026
## Describe your changes Bugfix in quantized model export. Bias weight was not set correctly before. ## Checklist before requesting a review - [ ] Add unit tests for this change. - [ ] Make sure all tests can pass. - [ ] Update documents if necessary. - [ ] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. - [ ] Is this PR including examples changes? If yes, please remember to update [example documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md) in a follow-up PR. ## (Optional) Issue link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: CumSum() and Round() are new operators for ONNX opset 11
Motivation and Context
Add implementations of new operators to OnnxRuntime.