Android CI - #1600
Conversation
| "type":"git", | ||
| "git": { | ||
| "commitHash": "65b8e0f9979fbade16e3becbdfa69c0764946f72", | ||
| "commitHash": "a25e13886e00eed06620d9d59e1ac1eaa18b25b7", |
There was a problem hiding this comment.
This is what's in the description "Update ONNX for onnx/onnx#2221, which fix segfault on Android"
but, @daquexian do you know the root cause in ONNX which leads to the segfault please? if yes, could you share more details about it please? Thank you!
There was a problem hiding this comment.
@snnn @linkerzhang It is a bug in onnx. ctx.getInputType(1) (https://github.com/onnx/onnx/pull/2221/files#diff-f24e7f9545820de198f21ac7c7d37d10R1542) is null on https://github.com/onnx/onnx/tree/master/onnx/backend/test/data/pytorch-operator/test_operator_repeat. It causes onnx_test_runner crash on this test case, so I proposed a PR to onnx to fix it.
|
/azp run |
|
Azure Pipelines successfully started running 21 pipeline(s), but failed to run 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 21 pipeline(s), but failed to run 1 pipeline(s). |
|
@linkerzhang @snnn could you please run the CI? BTW, is Android CI enabled now? |
|
/azp run |
|
Azure Pipelines successfully started running 21 pipeline(s), but failed to run 1 pipeline(s). |
|
@snnn Could you please trigger the CI again? I have fixed windows ci |
|
|
||
| #if (defined(__amd64__) || defined(_M_X64)) && not defined(__ANDROID__) | ||
| #if defined(__amd64__) || defined(_M_X64) | ||
| #ifndef __ANDROID__ |
There was a problem hiding this comment.
I don't understand. In which case they could be both defined?
There was a problem hiding this comment.
Android can run on x86 and x64 processors, e.g., android x64 emulators
|
/azp run |
|
Azure Pipelines successfully started running 21 pipeline(s), but failed to run 1 pipeline(s). |
|
@snnn @linkerzhang Build passed but CI failed due to an error "The Component Detection tool experienced a failure. See the logs for more information" |
|
@linkerzhang @snnn @shahasad Android CI works now |
|
/azp run |
|
Azure Pipelines successfully started running 19 pipeline(s). |
|
The Android CI fails on the code (when master is merged) |
|
@shahasad Pranav will fix the test error. |
…1600) ## Describe your changes - `onnxruntime.tools.onnx_model_utils.fix_output_shapes` cannot handle large models (#1595), so we use the ort shape infer helper and handle the logic ourselves. This also means it can now handle models with contrib operators too. - allow passing 0 as dim_value. this case is possible when creating a prompt processing model from a dynamic shaped llm where we want to make the past kv cache empty. ## Checklist before requesting a review - [ ] Add unit tests for this change. - [ ] Make sure all tests can pass. - [ ] Update documents if necessary. - [ ] Lint and apply fixes to your code by running `lintrunner -a` - [ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes. - [ ] Is this PR including examples changes? If yes, please remember to update [example documentation](https://github.com/microsoft/Olive/blob/main/docs/source/examples.md) in a follow-up PR. ## (Optional) Issue link
Description:
Update ONNX for Fix segfault in tile shape inference onnx/onnx#2221, which fix segfault on Android
Some misc changes to pass Android CI
Currently, the yaml file of Android CI is tools/ci_build/github/azure-pipelines/android-x86_64-crosscompile-ci-pipeline.yml